Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.7 branch Actions: Always read Node.js version from .nvmrc filewp/5.7 branch Actions: Always read the Node.js version from .nvmrc
Part of #82936.
What?
Replaces the three remaining hardcoded
node-version: 14.xvalues inwp/5.7'sactions/setup-nodesteps withnode-version-file: '.nvmrc', so.nvmrcis the single source of truth for the Node.js version this branch tests against:end2end-test.ymladminstatic-checks.ymlcheckunit-test.ymlunit-phpEach of these steps was also named
Use Node.js 14.x, so the name is shortened toUse Node.js, matching the steps that already read.nvmrc. All fiveactions/setup-nodesteps on this branch are now named and configured the same way. One commit per workflow.No functional change.
.nvmrcreads14, which resolves to the same Node.js release as the14.xrange these steps requested.Why?
create-block.ymlandunit-test.yml'sunit-jsjob already read.nvmrc, while the three steps above still hardcoded the version. A future Node.js bump would have to update.nvmrcand all three workflows, and nothing would fail if one were missed.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.