Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The concurrency keys allow unrelated fork PRs with identical branch names to cancel each other's checks.
1 open finding
What changed in this PR
Adds native GitHub Actions concurrency controls to five workflows as part of restoring wp/5.7 CI.
Changes:
- Enables cancellation of unfinished runs sharing a concurrency group.
- Groups runs by workflow and PR source branch, with a commit-SHA fallback for other events.
| File | Description |
|---|---|
.github/workflows/unit-test.yml |
Adds unit-test concurrency controls. |
.github/workflows/static-checks.yml |
Adds static-check concurrency controls. |
.github/workflows/end2end-test.yml |
Adds end-to-end test concurrency controls. |
.github/workflows/create-block.yml |
Adds Create Block check concurrency controls. |
.github/workflows/bundle-size.yml |
Adds compressed-size check concurrency controls. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.7 branch Actions: add concurrency configuration to workflowswp/5.7 branch Actions: Add concurrency configuration to workflows
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
LGTM! Tiniest of nits is that these old files still use 2 character indents instead of the 4 character indent this cherry-pick introduces. I don't think that's an issue because these blocks should still be read correctly (and it makes for a smaller diff not to re-do these files to the 4 character indent used in trunk). But, just thought I'd mention in case it wasn't intentional.
Given that this is a cosmetic issue only, and the PR is sitting at 5/36, I don't think it's worth rebasing the entire stack to address that. Let's leave it as is. |
Part of #82936.
What?
Adds a
concurrency:block to every relevant GitHub Actions workflow on this branch, so a pull request's in-progress run is cancelled when a newer commit is pushed to it.The
cancel.ymlworkflow this replaces is removed further down the stack, in #84762, alongside this branch's other obsolete workflows.Why?
Ports upstream trunk commit
7b39dd71905cb7e546857741e3d52e977ec36691, "Replace the Cancel workflow with native GitHub Action functionality" (#32016).Use of AI Tools
This PR was authored with the help of Claude Code.