Skip to content

Repair wp/7.0 branch Actions: Set explicit retention periods for workflow artifacts - #84744

Open
desrosj wants to merge 1 commit into
fix-actions-7.0/disable-node-modules-cache-in-storybook-checkfrom
fix-actions-7.0/set-artifact-retention-days
Open

Repair wp/7.0 branch Actions: Set explicit retention periods for workflow artifacts#84744
desrosj wants to merge 1 commit into
fix-actions-7.0/disable-node-modules-cache-in-storybook-checkfrom
fix-actions-7.0/set-artifact-retention-days

Conversation

@desrosj

@desrosj desrosj commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82782.

What?

Sets retention-days on the artifacts that trunk's #84525 covers, or their equivalents on this branch, which otherwise fall back to GitHub's 90-day default:

File Artifact Retention
build-plugin-zip.yml Plugin ZIPs 14 days for pull requests (pushes keep 90)
end2end-test.yml E2E failure artifacts (screenshots, HTML snapshots) 14 days
unit-test.yml Unit test build-assets 3 days

Why?

None of these are read for anywhere near 90 days. build-assets is handed between jobs of the same run. The plugin ZIPs from pull requests are replaced by the next push. The rest is debugging output for a failed run.

Trunk set explicit retention periods for its large artifacts in b48f801 (#84525), matching what WordPress/wordpress-develop#13527 did for core.

How?

  • Uses trunk's values and comments for the artifacts trunk changed.
  • Trunk no longer uploads E2E failure artifacts (its Playwright jobs upload blob reports instead), so they get the 14 days trunk uses for the performance workflow's failure artifacts.
  • This branch doesn't upload the other artifacts trunk changed: performance traces, performance source maps, performance failure artifacts or Playwright HTML report.
  • Each retention-days goes at the end of the upload step's with: block. Nothing else changes.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 15, 2026
@desrosj desrosj self-assigned this Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7530b889-b504-4725-aed4-87c8c2a434b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #84468 October 15, 2026 01:46
@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj marked this pull request as ready for review October 15, 2026 03:38
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj force-pushed the fix-actions-7.0/set-artifact-retention-days branch from 665573f to 2fef435 Compare October 19, 2026 17:04
@desrosj
desrosj removed this pull request from stack #84468 October 21, 2026 18:35
@desrosj
desrosj added this pull request to stack #85325 October 21, 2026 18:35
ntsekouras
ntsekouras approved these changes Oct 23, 2026
View reviewed changes

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@desrosj
desrosj force-pushed the fix-actions-7.0/set-artifact-retention-days branch from 2fef435 to 3aff552 Compare October 23, 2026 17:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ntsekouras