Repository navigation
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
Adi-ty
marked this pull request as ready for review
October 15, 2026 05:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #84699
Sizes the image lightbox overlay to the area the browser actually lays fixed content out in, instead of hardcoding 100vh. On iOS Safari that area is shorter than 100vh, so the overlay used to overflow the visible screen. Also measures the overlay in view.js so the zoom still starts from the thumbnail.
Why?
On iOS Safari the lightbox had two visible problems, both from one root cause — .wp-lightbox-overlay was height: 100vh, taller than the area Safari lays fixed content out in:
How?
.wp-lightbox-overlayusesinset: 0instead ofwidth: 100%; height: 100vh, so it matches the area the browser lays fixed content out in, and the image containers'top: 50%centers on the visible screen.setOverlayStyles()inview.jsmeasures the overlay and sizes the image against its height instead ofwindow.innerHeight. It passes the height to CSS as--wp--lightbox-overlay-height, which replaces-50vhin the zoom keyframes so the zoom still starts from the thumbnail.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools
Assisted by Claude Code, all changes tested & reviewed manually.