Repository navigation
fix(env): honor testsEnvironment default of false - #84711
Open
Hug0-Drelon wants to merge 2 commits into
Open
Hug0-Drelon wants to merge 2 commits into
Hug0-Drelon wants to merge 2 commits into
Conversation
Align wp-env runtime behavior with the documented default so omitting testsEnvironment no longer starts the legacy tests stack or shows a deprecation warning when using --config. Fixes WordPress#84710 Co-authored-by: Cursor <cursoragent@cursor.com>
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Aligns wp-env runtime behavior with the documented
testsEnvironmentdefault offalse.Why?
Fixes #84710. The README and JSON schema document
testsEnvironmentas defaulting tofalse, but the code treated an omitted value astrue, starting the legacy tests stack (tests-wordpress,tests-cli, port8889, etc.) and showing a deprecation warning — even when using--configwith a dedicated test config file.How?
testsEnvironmenttofalsein config parsing.testsEnvironmentis explicitlytrue.--config).wp-env.jsonschema default.Test plan
npm run test:unit:vitest -- packages/envwp-env startwith a minimal.wp-env.json(notestsEnvironment) starts only the development environment — notests-*containers, no deprecation warning.wp-env start --config .wp-env.test.jsonstarts a single environment with no deprecation warning."testsEnvironment": truestill starts both environments (with deprecation warning on the default config).Made with Cursor