Repository navigation
Add classname instead of inline background color when using Text Highlight - #84609
Open
Vedant-Gandhi wants to merge 6 commits into
Open
Vedant-Gandhi wants to merge 6 commits into
Vedant-Gandhi wants to merge 6 commits into
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
#49332
How?
Add logic to detect if selected background color is used from palette and add it as
has-*syntax instead of inlining the color else fallback to color inlining.Testing Instructions
has-*-background-color.Screenshots or screencast tp
Use of AI Tools
I have used Claude Sonnet 5.5 or reviewed the issue as well as using it as an assistant to write the code. It has also been used to write comments in the code as well as reivewing the test cases and updating them as needed. I have thoroughly reviewed the code and ensured it does not introduce any side effects on other components apart from the fix being introduced.