Repository navigation
Repair wp/6.4 branch Actions: Skip the flaky multiple completers autocomplete e2e test - #84589
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.63 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
0729a53 to
bfad94e
Compare
wp/6.4 branch Actions: Fix flaky multiple completers autocomplete e2e testwp/6.4 branch Actions: Skip the flaky multiple completers autocomplete e2e test
bfad94e to
4cdf3eb
Compare
ramonjd
left a comment
There was a problem hiding this comment.
| Run | Result | |
|---|---|---|
| Before (base branch) | 38332351621 | Playwright - 2: 1 failed, 227 passed. All 3 tries time out waiting for the "Bilbo Baggins" option |
| Before, with the #55081 waits ported | 38334453973 | Same test, same timeout on "Bilbo Baggins" |
| After (this PR) | 39291571758 | Playwright - 2: 227 passed, 1 skipped (same 228 tests) |
| Top of the 6.4 stack | #85134 | All 7 e2e jobs pass |
4cdf3eb to
a581c04
Compare
a581c04 to
a6923a1
Compare
Part of #82929.
What?
Skips the
Autocomplete › should insert elements from multiple completers in a single blocke2e test intest/e2e/specs/editor/various/autocomplete-and-mentions.spec.js, with a comment saying why.Why?
The test is flaky on this branch because of an autocomplete bug, not the test. After the test inserts
@ringbearerfrom the@user completer, the autocomplete sometimes reopens the user popover on that mention (the browser requests/wp/v2/users?search=ringbearer). The test's next input,+bi, then goes into that search (search=ringbearer +bi, which matches no users), so the+completer never opens and the "Bilbo Baggins" option never appears.When it happens, it fails all three attempts in the run. It failed on #83688, #83805 and #83826 (https://github.com/WordPress/gutenberg/actions/runs/38006840735, https://github.com/WordPress/gutenberg/actions/runs/38332351621), but passed on #83689 and #83838. Porting the waits from #55081 doesn't help: the test then waits for the first mention to land, and the popover still reopens (https://github.com/WordPress/gutenberg/actions/runs/38334453973).
How?
test.skip(), astemplate-part.spec.jsalready does on this branch. Trunk fixed the bug itself in #77185 (April 2026), inpackages/components' autocomplete code. Backporting that would change editor code that ships with the plugin, which is out of scope for this branch.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code