Skip to content

Repair wp/6.0 branch Actions: Add timeouts to CI jobs that have none - #84487

Open
desrosj wants to merge 1 commit into
fix-actions-6.0/remove-rn-workflowsfrom
fix-actions-6.0/add-job-timeouts
Open

Repair wp/6.0 branch Actions: Add timeouts to CI jobs that have none#84487
desrosj wants to merge 1 commit into
fix-actions-6.0/remove-rn-workflowsfrom
fix-actions-6.0/add-job-timeouts

Conversation

@desrosj

@desrosj desrosj commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82933.

What?

Adds timeout-minutes to the following CI jobs on this branch, which don't have one:

File Job Check Minutes Trunk
bundle-size.yml build Compressed Size Check 30 15
create-block.yml checks Create Block 20 10
end2end-test-playwright.yml e2e E2E Tests (Playwright) 45 none
end2end-test.yml admin Admin e2e 45 none
static-checks.yml check Static Analysis All 30 30
unit-test.yml unit-php PHP 20 20

Why?

Without timeout-minutes, a stuck job runs until GitHub's 360-minute default. On 2026-10-07, Playwright shards on wp/7.1–wp/6.2 hung for 2.3–3 hours in playwright install --with-deps while an Ubuntu apt mirror was degraded. Trunk added job timeouts for this in 27f57c9 (#80801).

This branch doesn't run --with-deps, so here the timeouts guard against hangs in general.

How?

Uses trunk's values from #80801 and 9ee17a7 (#46510) where this branch's job durations fit under them, and raises them where they don't, because on these branches every job builds and installs on its own without trunk's shared build and apt cache:

  • Compressed Size Check: Runs on other wp/X.Y branches have taken 14.2 minutes, so trunk's 15 is too tight.
  • Create Block: Runs on other wp/X.Y branches have taken 11.1 minutes, so trunk's 10 would cut them off.
  • E2E Tests (Playwright): It installs Chromium only. The slowest run took 15.2 minutes.
  • Admin e2e: CI: Add job timeouts to E2E, static checks, bundle size, and create block #80801 doesn't cover the Puppeteer e2e jobs. The slowest run took 17.8 minutes.

Each timeout-minutes goes next to the job's runs-on. There is no step-level timeout on dependency installs: successful installs have taken up to 21 minutes.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 10, 2026
@desrosj desrosj self-assigned this Oct 10, 2026
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a74620e5-7e11-4316-a876-41f686a43d3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #84488 October 10, 2026 00:16
@desrosj desrosj mentioned this pull request Oct 13, 2026
Open
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 01:14
@github-actions

github-actions Bot commented Oct 13, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@adimoldovan
adimoldovan self-requested a review October 19, 2026 15:05
adimoldovan
adimoldovan approved these changes Oct 19, 2026
View reviewed changes

@adimoldovan adimoldovan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI failures are not relevant to the changes of this PR.

@desrosj
desrosj removed this pull request from stack #84488 October 21, 2026 15:57
@desrosj
desrosj added this pull request to stack #85301 October 21, 2026 15:59
@desrosj
desrosj removed this pull request from stack #85301 October 21, 2026 19:46
@desrosj
desrosj added this pull request to stack #85348 October 21, 2026 19:46
@desrosj
desrosj removed this pull request from stack #85348 October 22, 2026 17:52
@desrosj
desrosj added this pull request to stack #85405 October 22, 2026 17:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adimoldovan adimoldovan adimoldovan approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @adimoldovan