Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84470
October 9, 2026 23:35
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:15
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adimoldovan
self-requested a review
October 19, 2026 14:54
adimoldovan
approved these changes
Oct 19, 2026
adimoldovan
left a comment
adimoldovan
left a comment
Contributor
There was a problem hiding this comment.
Looks good. CI failures are not relevant to the changes of this PR.
desrosj
removed this pull request from stack #84470
October 21, 2026 18:33
desrosj
added this pull request to stack #85323
October 21, 2026 18:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Adds
timeout-minutesto the following CI jobs on this branch, which don't have one:bundle-size.ymlbuildCheckcreate-block.ymlchecksend2end-test.ymle2e-playwrightend2end-test.ymlmerge-artifactsstatic-checks.ymlcheckAllWhy?
Without
timeout-minutes, a stuck job runs until GitHub's 360-minute default. On 2026-10-07, Playwright shards onwp/7.1–wp/6.2hung for 2.3–3 hours inplaywright install --with-depswhile an Ubuntu apt mirror was degraded. Trunk added job timeouts for this in 27f57c9 (#80801).This branch runs
--with-deps, so the same hang can happen here.How?
Uses trunk's values from #80801 and 9ee17a7 (#46510) where this branch's job durations fit under them, and raises them where they don't, because on these branches every job builds and installs on its own without trunk's shared build and apt cache:
Check: Runs on otherwp/X.Ybranches have taken 14.2 minutes, so trunk's 15 is too tight.wp/X.Ybranches have taken 11.1 minutes, so trunk's 10 would cut them off.Each
timeout-minutesgoes next to the job'sruns-on. There is no step-level timeout on dependency installs: successful installs have taken up to 21 minutes.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code