Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a5fcb70 to
8575aa4
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Closing in favor of #84873, which removes the object-fit polyfill instead of moving its URL to another CDN. WordPress 5.8 registers its own polyfill, so the plugin's copy isn't needed on |
Part of #82935.
What?
Changes the
objectFitPolyfillvendor script URL inlib/client-assets.phpfrom unpkg to jsDelivr, keeping the same package, version (2.3.5) and file path.Why?
https://unpkg.com/objectFitPolyfill@2.3.5/dist/objectFitPolyfill.min.jsnow returns 404 (Package not found).bin/build-plugin-zip.sh(npm run build:plugin-zip) downloads the registered vendor scripts and exits on any non-200 response, so the plugin zip for this branch can't be built at all. In development mode,gutenberg_register_vendor_script()also requests the URL at runtime and, when it can't download it, enqueues the dead URL instead.unpkg lowercases package names since moving to Cloudflare Workers, so it can no longer serve legacy npm packages with capital letters in their names. The maintainers closed the report as not planned (unpkg/unpkg#453). The package itself is unchanged on npm.
Trunk removed the polyfill in #34536 (351e52c) and the build-time vendor downloads in #39534 (1639284). Neither is suitable here: this branch still supports WordPress 5.6, and #39534 rewrites the build pipeline.
How?
jsDelivr serves the same npm file (the
2.3.5file is byte-identical to the npm tarball's). The file is still downloaded at build time and shipped in the plugin'svendor/directory, so browsers never request it from the CDN. Only the vendor filename's hash changes; nothing references that filename directly.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code