Skip to content

Repair wp/5.8 branch Actions: Initialize WP_Block_Supports::$block_to_render and showSubmenuIcon context in the Navigation Link render tests - #84451

Open
desrosj wants to merge 2 commits into
fix-actions-5.8/pin-mariadb-versionfrom
fix-actions-5.8/fix-phpunit-testcode-compat
Open

Repair wp/5.8 branch Actions: Initialize WP_Block_Supports::$block_to_render and showSubmenuIcon context in the Navigation Link render tests#84451
desrosj wants to merge 2 commits into
fix-actions-5.8/pin-mariadb-versionfrom
fix-actions-5.8/fix-phpunit-testcode-compat

Conversation

@desrosj

@desrosj desrosj commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82935.

What?

Two changes to phpunit/class-block-library-navigation-link-test.php, test code only:

  1. Saves, sets and restores WP_Block_Supports::$block_to_render in setUp()/tearDown().
  2. Passes array( 'showSubmenuIcon' => false ) as the context of the 7 new WP_Block() calls.

Why?

  1. The tests call the block's render function directly, so WP_Block_Supports::$block_to_render is null when get_block_wrapper_attributes() reads it (Trying to access array offset on value of type null). That is a warning, converted to an error, on PHP 8.
  2. This branch's packages/block-library/src/navigation-link/index.php:205 reads $block->context['showSubmenuIcon'] without checking that it is set; wp/5.9 added an isset() there. With an empty context that read also errors on PHP 8.

Both surface once the PHP 8.0 legs run, which #84455, later in this stack, enables. On this branch the PHP 7.4 and PHP 8.0 legs of unit-test.yml currently stop before any test runs (wp-phpunit/wp-phpunit 5.6.0 refuses PHPUnit 8 and newer), and the PHP 5.6 legs stop on a PHPUnit parse error. #84455 and #84456 fix those. Only the PHP 7.0 legs (PHPUnit 6.5.14) run these tests today.

How?

Adapted from wp/6.0's #84286 and wp/5.9's #84419. The block_to_render hunk is theirs with camelCase setUp()/tearDown(): this branch's wp-phpunit/wp-phpunit 5.6.0 test case never calls set_up()/tear_down(), so the snake_case methods would never run. The showSubmenuIcon context is specific to this branch.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 9, 2026
@desrosj desrosj self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cacc8f21-d22e-44ea-bccb-ae8b09d8ea09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 9, 2026
Open
Closed
@desrosj
desrosj added this pull request to stack #84460 October 9, 2026 18:29
@desrosj
desrosj removed this pull request from stack #84460 October 10, 2026 00:22
@desrosj
desrosj changed the base branch from fix-actions-5.8/replace-db-check-with-healthcheck to wp/5.8 October 10, 2026 00:23
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-phpunit-testcode-compat branch from fe3e8bf to 664fcb4 Compare October 10, 2026 00:24
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/pin-mariadb-version October 10, 2026 00:26
@desrosj
desrosj added this pull request to stack #84492 October 10, 2026 00:27
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 01:10
@github-actions

github-actions Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj removed this pull request from stack #84492 October 16, 2026 01:21
@desrosj
desrosj added this pull request to stack #84874 October 16, 2026 01:21
@desrosj
desrosj removed this pull request from stack #84874 October 16, 2026 15:49
@desrosj
desrosj added this pull request to stack #84943 October 16, 2026 15:50
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-phpunit-testcode-compat branch from 664fcb4 to 581137d Compare October 19, 2026 17:09
ramonjd
ramonjd approved these changes Oct 21, 2026
View reviewed changes

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Before (base PR) After (this PR) Top of stack
#84451 wp/5.8 PHP 8.0 stops before any test runs: PHPUnit 9.6.21 ... only compatible with PHPUnit up to 7.x PHP 5.6 stops on a PHPUnit parse error, as the description expects #84756: all 8 PHP jobs pass; PHP 8.0 runs 201 tests with 0 errors

@desrosj
desrosj removed this pull request from stack #84943 October 21, 2026 19:47
@desrosj
desrosj added this pull request to stack #85352 October 21, 2026 19:48
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-phpunit-testcode-compat branch from 581137d to 10bd88a Compare October 22, 2026 18:35
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-phpunit-testcode-compat branch from 10bd88a to a84abbd Compare October 23, 2026 13:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd ramonjd approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ramonjd