Skip to content

Repair wp/5.8 branch Actions: Fix Test Widget e2e plugin for PHP 8 - #84447

Open
desrosj wants to merge 1 commit into
fix-actions-5.8/fix-xdebug-pecl-php7from
fix-actions-5.8/fix-test-widget-php8-compat
Open

Repair wp/5.8 branch Actions: Fix Test Widget e2e plugin for PHP 8#84447
desrosj wants to merge 1 commit into
fix-actions-5.8/fix-xdebug-pecl-php7from
fix-actions-5.8/fix-test-widget-php8-compat

Conversation

@desrosj

@desrosj desrosj commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82935.

What?

Matches Test_Widget::update() in the e2e test plugin (packages/e2e-tests/plugins/class-test-widget.php) to the parent signature, WP_Widget::update( $new_instance, $old_instance ). It also guards the $instance['title'] read in form() with isset(), as upstream does. Only the e2e test plugin changes.

Why?

On PHP 8 (which wp-env uses here, since .wp-env.json sets no phpVersion), the incompatible update( $new_instance ) signature is a fatal error. WordPress refuses to activate the gutenberg-test-widgets plugin, so specs/widgets/customizing-widgets.test.js times out in activatePlugin() on every run.

Upstream

A straight port of #34355 (b2c4a00), which applies cleanly. That fix reached wp/5.9 but never wp/5.8. wp/5.7 and older don't have this plugin.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added [Type] Build Tooling Issues or PRs related to build tooling [Package] E2E Tests /packages/e2e-tests labels Oct 9, 2026
@desrosj desrosj self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fab93ccb-d830-43c7-9ed9-c98201d55bc5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 9, 2026
Open
Closed
@desrosj
desrosj added this pull request to stack #84460 October 9, 2026 18:29
@desrosj
desrosj removed this pull request from stack #84460 October 10, 2026 00:22
@desrosj
desrosj changed the base branch from fix-actions-5.8/fix-xdebug-pecl-php7 to wp/5.8 October 10, 2026 00:23
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-test-widget-php8-compat branch from 019e7f0 to 0f9d7c6 Compare October 10, 2026 00:24
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/fix-xdebug-pecl-php7 October 10, 2026 00:26
@desrosj
desrosj added this pull request to stack #84492 October 10, 2026 00:27
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 01:09
@github-actions

github-actions Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj removed this pull request from stack #84492 October 16, 2026 01:21
@desrosj
desrosj added this pull request to stack #84874 October 16, 2026 01:21
@desrosj
desrosj removed this pull request from stack #84874 October 16, 2026 15:49
@desrosj
desrosj added this pull request to stack #84943 October 16, 2026 15:50
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-test-widget-php8-compat branch from 0f9d7c6 to 9ff39c9 Compare October 19, 2026 17:09
@desrosj
desrosj removed this pull request from stack #84943 October 21, 2026 19:47
@desrosj
desrosj added this pull request to stack #85352 October 21, 2026 19:48
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-test-widget-php8-compat branch from 9ff39c9 to 0159db4 Compare October 22, 2026 18:35
andrewserong
andrewserong approved these changes Oct 23, 2026
View reviewed changes

@andrewserong andrewserong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Matches #34355 exactly

@desrosj
desrosj force-pushed the fix-actions-5.8/fix-test-widget-php8-compat branch from 0159db4 to f64f3cf Compare October 23, 2026 13:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewserong andrewserong andrewserong approved these changes

Assignees

@desrosj desrosj

Labels

[Package] E2E Tests /packages/e2e-tests [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @andrewserong