Skip to content

Repair wp/5.8 branch Actions: Fetch react-native-screens as a pre-built tarball - #84445

Open
desrosj wants to merge 1 commit into
fix-actions-5.8/fix-activate-theme-navigation-racefrom
fix-actions-5.8/fix-react-native-screens-git-dependency
Open

Repair wp/5.8 branch Actions: Fetch react-native-screens as a pre-built tarball#84445
desrosj wants to merge 1 commit into
fix-actions-5.8/fix-activate-theme-navigation-racefrom
fix-actions-5.8/fix-react-native-screens-git-dependency

Conversation

@desrosj

@desrosj desrosj commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82935.

What?

Changes the react-native-screens dependency in packages/react-native-editor/package.json from a git URL to a pre-built tarball, with the matching package-lock.json entries:

  • From: git+https://github.com/wordpress-mobile/react-native-screens.git#b3d907bda2695743f35fd874261dcd27e0912eca
  • To: https://raw.githubusercontent.com/wordpress-mobile/react-native-screens/a25c3d81e0838d57c9f9ac77ef726751e329bad1/react-native-screens-2.9.0-wp-1.tgz

Why?

npm ci fails in every CI job that installs dependencies, so nothing after it runs:

npm ERR! prepareGitDep > react-native-screens@2.9.0 prepare
npm ERR! prepareGitDep node_modules/@types/node/buffer.d.ts:77:19 - error TS1005: ',' expected.

For a git dependency, npm clones the repository and runs its prepare script, here bob build, which runs tsc:

  • react-native-screens doesn't pin @types/node, so tsc gets the newest release from npm.
  • Its typescript range (^3.8.3) resolves to TypeScript 3.9, which can't parse syntax from TypeScript 4.0–4.5 that current @types/node uses.
  • tsc fails with TS1005/TS1109/TS1110, and so does npm ci.

A tarball already contains the built lib/ output, so npm doesn't run prepare. wp/5.9 already uses this exact tarball.

How?

The tarball is built from wordpress-mobile/react-native-screens@a25c3d8, a descendant of the commit this branch pinned (wordpress-mobile/react-native-screens@b3d907b).

  • src/ is identical between the two commits. The only differences are Android/Gradle build files, the podspec, and the version string (2.9.0 → 2.9.0-wp-1), so this changes packaging, not behavior.
  • The tarball ships lib/commonjs, lib/module and lib/typescript already built.
  • The integrity value in package-lock.json matches the SHA-512 of the downloaded tarball, and the value wp/5.9 uses for the same file.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 9, 2026
@desrosj desrosj self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b47da62b-f571-4ce3-a0c2-f20f2613fe93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 9, 2026
Open
Closed
@desrosj
desrosj added this pull request to stack #84460 October 9, 2026 18:29
@desrosj
desrosj removed this pull request from stack #84460 October 10, 2026 00:22
@desrosj
desrosj changed the base branch from fix-actions-5.8/fix-activate-theme-navigation-race to wp/5.8 October 10, 2026 00:23
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-react-native-screens-git-dependency branch from 38c171c to b8e7bde Compare October 10, 2026 00:24
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/fix-activate-theme-navigation-race October 10, 2026 00:26
@desrosj
desrosj added this pull request to stack #84492 October 10, 2026 00:27
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 01:09
@github-actions

github-actions Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj removed this pull request from stack #84492 October 16, 2026 01:21
@desrosj
desrosj added this pull request to stack #84874 October 16, 2026 01:21
@desrosj
desrosj removed this pull request from stack #84874 October 16, 2026 15:49
@desrosj
desrosj added this pull request to stack #84943 October 16, 2026 15:50
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-react-native-screens-git-dependency branch from b8e7bde to 16e8cf9 Compare October 19, 2026 17:09
@ramonjd ramonjd mentioned this pull request Oct 21, 2026
Open
@desrosj
desrosj removed this pull request from stack #84943 October 21, 2026 19:47
@desrosj
desrosj added this pull request to stack #85352 October 21, 2026 19:48
ntsekouras
ntsekouras approved these changes Oct 22, 2026
View reviewed changes

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! npm ci now passes in every job, so JavaScript and All go green. Compressed Size and Admin 1-4 pass further up the stack.

@desrosj
desrosj force-pushed the fix-actions-5.8/fix-react-native-screens-git-dependency branch from 16e8cf9 to 931945f Compare October 22, 2026 18:35
@desrosj
desrosj force-pushed the fix-actions-5.8/fix-react-native-screens-git-dependency branch from 931945f to 76a63fc Compare October 23, 2026 13:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ntsekouras