Skip to content

Repair wp/5.8 branch Actions: Ignore the stale Browserslist data warning in unit tests - #84443

Open
desrosj wants to merge 1 commit into
fix-actions-5.8/configure-composer-advisory-policyfrom
fix-actions-5.8/ignore-browserslist-old-data
Open

Repair wp/5.8 branch Actions: Ignore the stale Browserslist data warning in unit tests#84443
desrosj wants to merge 1 commit into
fix-actions-5.8/configure-composer-advisory-policyfrom
fix-actions-5.8/ignore-browserslist-old-data

Conversation

@desrosj

@desrosj desrosj commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82935.

What?

Sets BROWSERSLIST_IGNORE_OLD_DATA=true in test/unit/jest.config.js, before Jest starts.

Why?

The JavaScript unit test job fails with 5 failed tests, all for the same reason:

Error: expect(jest.fn()).not.toHaveWarned(expected)

The warning is Browserslist's caniuse-lite is outdated. This branch locks caniuse-lite@1.0.30001228 (May 2021), and Browserslist compares the data's age against today's date, so the warning fires on every run and will keep firing. @wordpress/jest-preset-default fails any test that logs an unexpected warning, so every test that loads browserslist fails:

  • packages/babel-plugin-import-jsx-pragma/test/index.js
  • packages/babel-plugin-makepot/test/index.js
  • packages/warning/test/babel-plugin.js
  • packages/babel-preset-default/test/index.js
  • packages/browserslist-config/test/index.test.js

No code change causes this; it is only the passage of time.

How?

Same fix as wp/7.0's a468930 ("Tests: Ignore Browserslist old data warning in unit tests"), which turns the warning off at the source. wp/7.0's copy of the file has a process.env.TZ line to put it next to; this branch's doesn't, so the line goes after the transpiledPackageNames block. wp/5.9 (#84408) and wp/6.0 (#84275) place it the same way.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 9, 2026
@desrosj desrosj self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1b2f01f-8805-4a67-97e5-fc622d4ffbc3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 9, 2026
Open
Closed
@desrosj
desrosj added this pull request to stack #84460 October 9, 2026 18:29
@desrosj
desrosj removed this pull request from stack #84460 October 10, 2026 00:22
@desrosj
desrosj changed the base branch from fix-actions-5.8/configure-composer-advisory-policy to wp/5.8 October 10, 2026 00:23
@desrosj
desrosj force-pushed the fix-actions-5.8/ignore-browserslist-old-data branch from c577dea to aa76afc Compare October 10, 2026 00:24
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/configure-composer-advisory-policy October 10, 2026 00:26
@desrosj
desrosj added this pull request to stack #84492 October 10, 2026 00:27
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 01:09
@github-actions

github-actions Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj removed this pull request from stack #84492 October 16, 2026 01:21
@desrosj
desrosj added this pull request to stack #84874 October 16, 2026 01:21
@desrosj
desrosj removed this pull request from stack #84874 October 16, 2026 15:49
@desrosj
desrosj added this pull request to stack #84943 October 16, 2026 15:50
@desrosj desrosj changed the title Repair wp/5.8 branch Actions: Ignore Browserslist old-data warning in unit tests Repair wp/5.8 branch Actions: Ignore the stale Browserslist data warning in unit tests Oct 16, 2026
@desrosj
desrosj force-pushed the fix-actions-5.8/ignore-browserslist-old-data branch from aa76afc to fc0aa5e Compare October 19, 2026 17:09
ramonjd
ramonjd approved these changes Oct 21, 2026
View reviewed changes

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch PR Browserslist Base PR, JS unit This PR, JS unit
5.8 #84443 4.14.2–4.16.6 npm ci fails before tests npm ci fails before tests (fixed by row AG, #84445)

@desrosj
desrosj removed this pull request from stack #84943 October 21, 2026 19:47
@desrosj
desrosj added this pull request to stack #85352 October 21, 2026 19:48
@desrosj
desrosj force-pushed the fix-actions-5.8/ignore-browserslist-old-data branch from fc0aa5e to 88383b4 Compare October 22, 2026 18:35
@desrosj
desrosj force-pushed the fix-actions-5.8/ignore-browserslist-old-data branch from 88383b4 to 8e1d93d Compare October 23, 2026 13:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd ramonjd approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ramonjd