Skip to content

Repair wp/5.8 branch Actions: Configure the Composer advisory policy - #84442

Open
desrosj wants to merge 1 commit into
fix-actions-5.8/pin-composer-imagefrom
fix-actions-5.8/configure-composer-advisory-policy
Open

desrosj wants to merge 1 commit into
fix-actions-5.8/pin-composer-imagefrom
fix-actions-5.8/configure-composer-advisory-policy

Conversation

@desrosj

@desrosj desrosj commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Part of #82935.

What?

Adds a config.policy.advisories.ignore-id block to composer.json for PKSA-mh9b-91zm-m1gy, with the reason it doesn't apply as its description.

Why?

Current Composer releases refuse to load package versions covered by a security advisory during resolution. Every wp-coding-standards/wpcs release that satisfies this branch's ^2.2 requirement is covered by one, so composer update fails outright:

Problem 1
  - Root composer.json requires wp-coding-standards/wpcs ^2.2, found wp-coding-standards/wpcs[2.2.0, 2.2.1, 2.3.0] but these were not loaded, because they are affected by security advisories ("PKSA-mh9b-91zm-m1gy").
  • PKSA-mh9b-91zm-m1gy (CVE-2026-45293) — an eval()-injection bug in wp-coding-standards/wpcs' WordPress.WP.EnqueuedResourceParameters sniff. That sniff ships only in the WordPress and WordPress-Extra rulesets. This branch's phpcs.xml.dist pulls in WordPress-Core and WordPress-Docs plus a handful of individually-named sniffs, and references neither of those two rulesets, so the vulnerable sniff is never loaded at any wpcs version.

It is the only ID this branch's dependency graph trips — with it ignored, resolution completes.

This branch commits a composer.lock, and composer install from a lock skips the advisory check, so CI isn't blocked, but any composer update is.

config is not part of Composer's lock content hash, so the committed composer.lock stays valid unchanged.

Testing

Measured with Composer 2.10.3 on PHP 8.0.30, judging by exit code:

command before after
composer update 2 — ... not loaded, because they are affected by security advisories ("PKSA-mh9b-91zm-m1gy") 0

No other advisory ID is required.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 9, 2026
@desrosj desrosj self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1fe6295a-a101-4956-b3e3-2fa438b99ab9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #84460 October 9, 2026 18:29
@desrosj
desrosj removed this pull request from stack #84460 October 10, 2026 00:22
@desrosj
desrosj changed the base branch from fix-actions-5.8/pin-composer-image to wp/5.8 October 10, 2026 00:23
@desrosj
desrosj force-pushed the fix-actions-5.8/configure-composer-advisory-policy branch from 8082a20 to 73d3c80 Compare October 10, 2026 00:24
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/pin-composer-image October 10, 2026 00:26
@desrosj
desrosj added this pull request to stack #84492 October 10, 2026 00:27
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 01:08
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #84492 October 16, 2026 01:21
@desrosj
desrosj added this pull request to stack #84874 October 16, 2026 01:21
@desrosj
desrosj removed this pull request from stack #84874 October 16, 2026 15:49
@desrosj
desrosj added this pull request to stack #84943 October 16, 2026 15:50
@desrosj desrosj changed the title Repair wp/5.8 branch Actions: Configure Composer policy to ignore irrelevant advisories Repair wp/5.8 branch Actions: Configure the Composer advisory policy Oct 16, 2026
@desrosj
desrosj force-pushed the fix-actions-5.8/configure-composer-advisory-policy branch from 73d3c80 to fd48696 Compare October 19, 2026 17:09
@desrosj
desrosj removed this pull request from stack #84943 October 21, 2026 19:47
@desrosj
desrosj added this pull request to stack #85352 October 21, 2026 19:48
@desrosj
desrosj force-pushed the fix-actions-5.8/configure-composer-advisory-policy branch from fd48696 to 508eed7 Compare October 22, 2026 18:35
@desrosj
desrosj force-pushed the fix-actions-5.8/configure-composer-advisory-policy branch from 508eed7 to 92571e9 Compare October 23, 2026 13:50

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants