Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wp/5.8 branch Actions: Run PHP coding standards on the runner instead of inside wp-env
#84440
b0c783e to
f4f0997
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.8 branch Actions: Add a PHP-version test matrixwp/5.8 branch Actions: Add a PHP version test matrix
f4f0997 to
32801f0
Compare
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Everything red on this PR passes at the top of this stack (#84756).
Matrix matches the PHP compatibility table for this WordPress version: the lowest and highest supported minor of each PHP major.
32801f0 to
e179acc
Compare
Part of #82935.
What?
Runs the PHPUnit job in
unit-test.ymlacross a PHP version matrix:5.6,7.0,7.4and8.0, each as a single site and a multisite leg.WP_ENV_PHP_VERSIONis set from the matrix, sowp-envuses the matchingwordpress:php<version>images.Why?
.wp-env.jsonsets nophpVersion, so the job ran once, on whatever PHP version the floatingwordpressimages use, which this branch was never written for. The matrix tests the lowest and highest supported minor version of each major PHP version.How?
This branch's
packages/envalready readsWP_ENV_PHP_VERSION, so only the workflow changes. Composer still installs dependencies insidewp-env'scomposercontainer, from the committedcomposer.lock. Related PRs in this stack:wp/5.8branch Actions: Remove thespatie/phpunit-watcherdev dependency #84439, directly above this one, removesspatie/phpunit-watcher, which breaks the5.6and7.0legs.wp/5.8branch Actions: Run PHP coding standards on the runner instead of inside wp-env #84440 moves PHP coding standards checks into their own job. Until then, the lint step runs on every leg.wp/5.8branch Actions: Let the current Composer release install this branch's dependencies #84441 adds aconfig.platform.phpof7.4tocomposer.jsonand records it incomposer.lock.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code