Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fbdbad1 to
6163b0d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.8 branch Actions: single Node.js version testingwp/5.8 branch Actions: Test against a single Node.js version
lucatume
left a comment
lucatume
left a comment
There was a problem hiding this comment.
This PR splits the npm cache. The jobs changed here now use ${{ runner.os }}-node-npm-cache-..., but the PHP job (unit-test.yml:76) and static-checks.yml:40 still use ${{ runner.os }}-node-14-npm-cache-.... No workflow sets restore-keys, so every lockfile hash gets two ~/.npm entries with the same content, each starting cold. Nothing later in the stack (#84436 included) aligns the keys.
Drop -14 from the remaining keys, here or in #84436:
--- a/.github/workflows/unit-test.yml
+++ b/.github/workflows/unit-test.yml
@@
- key: ${{ runner.os }}-node-14-npm-cache-${{ hashFiles('**/package-lock.json') }}
+ key: ${{ runner.os }}-node-npm-cache-${{ hashFiles('**/package-lock.json') }}
--- a/.github/workflows/static-checks.yml
+++ b/.github/workflows/static-checks.yml
@@
- key: ${{ runner.os }}-node-14-npm-cache-${{ hashFiles('**/package-lock.json') }}
+ key: ${{ runner.os }}-node-npm-cache-${{ hashFiles('**/package-lock.json') }}
|
Thanks, good catch. Fixed here in fd726ffaac, which drops I checked the other |
Part of #82935.
What?
Eliminates every Node.js version-matrix dimension across
wp/5.8's workflows, falling back to the version pinned in.nvmrc(14) instead.unit-test.ymlunit-jsnode: ['12', '14']node-version-file: '.nvmrc'create-block.ymlchecksnode: ['12', '14']node-version-file: '.nvmrc'end2end-test.ymladminpart: [1,2,3,4],node: ['14']nodedimension removed,partsharding dimension kept;node-version-file: '.nvmrc'bundle-size.ymlbuildnode: ['14']node-version-file: '.nvmrc'This branch has no
actions/setup-nodecall anywhere withcheck-latest: trueset, so there was nothing to remove for that part of this change. The remaining hardcodednode-version: 14values (unit-test.yml'sunit-phpjob andstatic-checks.yml) are switched to.nvmrcby #84436.With the
nodematrix gone, the~/.npmcache key no longer includes a Node.js version: every job now uses${{ runner.os }}-node-npm-cache-<lockfile hash>. This includesunit-phpandstatic-checks.yml, whose keys hadnode-14written out. Without that, those two jobs would keep a separate cache entry with the same contents, and neither entry could fall back to the other since no job setsrestore-keys.Why?
wp/5.8is a frozen, security-maintenance-only branch that will never move off the Node version pinned in.nvmrc. Testing against Node12in addition to14(inunit-test.ymlandcreate-block.yml) or carrying a single-valuenodematrix dimension elsewhere never provided real coverage on this branch and only cost CI time. Reading the version from.nvmrcvianode-version-filealso means the workflow and.nvmrccan't drift out of sync, since there's only one place the version is declared.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.