Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
11d7625 to
68f7e5f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.8 branch Actions: remove the mobile-unit-js jobwp/5.8 branch Actions: Remove the mobile-unit-js job
Part of #82935.
What?
Removes the
mobile-unit-jsjob (job nameMobile) from.github/workflows/unit-test.yml.The job installs the full npm tree, runs
npx lerna run build, and then runsnpm run test-unit:native— on this branch that maps tocd test/native/ && cross-env NODE_ENV=test jest --config ./jest.config.js, the Jest suite covering the React Native mobile editor's JavaScript. (It is the oldertest-unit:nativescript, not trunk's latertest:native.)Why?
This job is not disabled on
wp/5.8, and it is not broken. Unlike the equivalent change onwp/7.0(#82810) andwp/6.9(#82875) — where the job carriesif: falsebecause React 19 broke the native tests — the job here carries the ordinaryif: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}condition and runs and passes. It is being removed for scope and consistency, not because of a failure.The reasoning is the React Native cleanup this stack already started. The bottom PR of this stack removes
rnmobile-android-runner.ymlandrnmobile-ios-runner.ymlon the grounds that React Native support is no longer maintained or shipped from Gutenberg, so its CI carries no ongoing value on a frozen, security-maintenance-only branch — only maintenance surface (action pins to track, extra runner minutes, extra signal to interpret). The mobile unit tests are the last remaining piece of that same surface on this branch, so they go with the E2E runners rather than being left behind as the one mobile job still wired up.Nothing else referenced the job: no
needs:entry names it, andunit-test.ymldeclares nooutputs:anywhere, so the remainingunit-js(JavaScript) andunit-php(PHP …) jobs are untouched. The file still parses as valid YAML with exactly those two jobs.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code