Repository navigation
Repair wp/5.9 branch Actions: Retry detached menu item clicks in the Widgets Customizer e2e tests - #84426
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/fix-create-user-field-typing
to
wp/5.9
October 10, 2026 00:18
desrosj
force-pushed
the
fix-actions-5.9/fix-flaky-customizer-inspector-test
branch
from
October 10, 2026 00:19
16b72ff to
50f9b48
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/fix-create-user-field-typing
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:02
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.9/fix-flaky-customizer-inspector-test
branch
from
October 19, 2026 17:09
50f9b48 to
d4626af
Compare
andrewserong
approved these changes
Oct 21, 2026
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
This looks like a pragmatic fix for the intermittent failures, and trying 3 times (guarded by detached) sounds good to me. The function looks clean and logical, and the call sites are all consistent.
LGTM!
desrosj
force-pushed
the
fix-actions-5.9/fix-flaky-customizer-inspector-test
branch
from
October 21, 2026 15:43
d4626af to
7d87ff9
Compare
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
…en the menu item is detached.
desrosj
force-pushed
the
fix-actions-5.9/fix-flaky-customizer-inspector-test
branch
from
October 23, 2026 13:43
7d87ff9 to
95582a5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
Adds a
clickMenuItem()helper to the Widgets Customizer e2e tests (packages/e2e-tests/specs/widgets/customizing-widgets.test.js) and uses it for the three "Show more settings" clicks in the block toolbar's Options menu. The helper finds the menu item and clicks it. If the click fails because the element was detached, it reopens the Options menu if the menu closed, finds the item again and retries, up to three attempts in total. Any other error is thrown as before.Why?
Widgets Customizer › should open the inspector panelfails intermittently on this branch withNode is detached from documentatshowMoreSettingsButton.click()("Admin - 4"). The test finds the menu item withfind(), then clicks the returned element handle, and the Options menu can re-render in between, so the click targets a node that is no longer in the document. Across 36Admin - 4jobs on this stack between 2026-10-06 and 2026-10-08, it failed on every attempt in 13 and passed only on a retry in 8.Trunk has no Puppeteer fix to backport. These tests were moved to Playwright in #39540 (9f5b842), whose locators look the element up again when clicking.
wp/5.9has no Playwright e2e setup, so this does the same thing within the Puppeteer test.How?
clickMenuItem( name )callsfind( { role: 'menuitem', name } )and.click()in a loop, and only retries when the error message contains "detached". Before a retry, if no[role="menu"]is open, it shows the block toolbar and clicks "Options" again, because the re-render that detaches the item can also close the menu. The test steps and assertions are unchanged.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code