Repository navigation
Repair wp/5.9 branch Actions: Check for a current screen before reading its ID in the global styles settings - #84424
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
This was referenced Oct 9, 2026
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/fix-pattern-directory-tests
to
wp/5.9
October 10, 2026 00:18
desrosj
force-pushed
the
fix-actions-5.9/fix-block-editor-current-screen-null
branch
from
October 10, 2026 00:19
bcdbaab to
4df58e4
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/fix-pattern-directory-tests
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:01
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
rejaulalomkhan
approved these changes
Oct 18, 2026
rejaulalomkhan
left a comment
rejaulalomkhan
left a comment
There was a problem hiding this comment.
Thanks for working on this, @desrosj!
Checking is_object( get_current_screen() ) before reading get_current_screen()->id cleanly avoids the PHP 8.0+ Attempt to read property "id" on null warning during test runs when $current_screen is null. The short-circuit evaluation preserves existing behavior when a screen exists. Matches trunk's fix in #39543. LGTM!
AI Review: Gemini 2.5 Pro (Antigravity)
desrosj
force-pushed
the
fix-actions-5.9/fix-block-editor-current-screen-null
branch
from
October 19, 2026 17:09
4df58e4 to
88a5c02
Compare
desrosj
force-pushed
the
fix-actions-5.9/fix-block-editor-current-screen-null
branch
from
October 21, 2026 15:43
88a5c02 to
4495c9d
Compare
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
…l styles settings.
desrosj
force-pushed
the
fix-actions-5.9/fix-block-editor-current-screen-null
branch
from
October 23, 2026 13:43
4495c9d to
c239115
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
In
gutenberg_experimental_global_styles_settings()(lib/global-styles.php), checks thatget_current_screen()returns a screen before reading itsid.Why?
The function checks that
get_current_screenis callable, but not that a screen has been set, and then readsget_current_screen()->id. When the block editor settings are built without a current screen, as inWP_Test_Block_Editor, that reads a property onnull. On PHP 8 this is a warning, which PHPUnit turns into an error, sotest_get_block_editor_settings_overrides_default_settings_all_editorsandtest_get_block_editor_settings_deprecated_filter_post_editorfail withAttempt to read property "id" on nullatlib/global-styles.php:21.How?
Adds
is_object( get_current_screen() ) &&to the condition, as trunk did in #39543 (3f19397). That commit doesn't cherry-pick here because the code had moved tolib/compat/wordpress-6.0/block-editor-settings.phpon trunk, so the same one-line change is applied tolib/global-styles.php.wp/6.0already has the check.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code