Repository navigation
Repair wp/5.9 branch Actions: Add wpop_keywords to the pattern directory test fixtures - #84423
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
This was referenced Oct 9, 2026
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/skip-media-text-float-fixture-before-php-7-1
to
wp/5.9
October 10, 2026 00:18
desrosj
force-pushed
the
fix-actions-5.9/fix-pattern-directory-tests
branch
from
October 10, 2026 00:19
072ed69 to
4a9d3c7
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/skip-media-text-float-fixture-before-php-7-1
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:01
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.9/fix-pattern-directory-tests
branch
from
October 19, 2026 17:09
4a9d3c7 to
3d3ec0d
Compare
desrosj
force-pushed
the
fix-actions-5.9/fix-pattern-directory-tests
branch
from
October 21, 2026 15:43
3d3ec0d to
77a14da
Compare
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
desrosj
force-pushed
the
fix-actions-5.9/fix-pattern-directory-tests
branch
from
October 23, 2026 13:43
77a14da to
c40f1a6
Compare
andrewserong
approved these changes
Oct 26, 2026
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
LGTM and matches how the core fixtures work 👍
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
Fixes the pattern directory REST controller tests (
phpunit/class-wp-rest-pattern-directory-controller-test.php):"wpop_keywords": ""to themetaof every pattern in the four fixtures inphpunit/fixtures/rest-api/pattern-directory/.test_get_items_by_keyword()that asserted every returned pattern has thecorekeyword.Why?
WordPress 5.9 ships its own
WP_REST_Pattern_Directory_Controller, so theclass_exists()check inlib/load.phpskips Gutenberg's copy and these tests run against core's class. Core's class reads each pattern's keywords frommeta->wpop_keywords, but the fixtures only havekeyword_slugs, which Gutenberg's class read:Undefined property: stdClass::$wpop_keywords(class-wp-rest-pattern-directory-controller.php:216).test_get_items_by_keyword()fails onassertContains( 'core', ... ).How?
Matches WordPress 5.9's own tests for this controller: core's fixtures (
tests/phpunit/data/blocks/pattern-directory/on the5.9branch of wordpress-develop) have"wpop_keywords": ""in the same place, and core'stest_get_items_by_keyword()has nocorekeyword assertion.keyword_slugsis kept in the fixtures.Trunk removed these tests and fixtures instead, in #38273 (596afcc), when the plugin's minimum WordPress version became 5.8.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code