Repository navigation
Repair wp/5.9 branch Actions: Initialize WP_Block_Supports::$block_to_render in the Navigation Link render tests - #84419
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
This was referenced Oct 9, 2026
Open
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/fix-url-details-array-assertions
to
wp/5.9
October 10, 2026 00:17
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-testcode-compat
branch
from
October 10, 2026 00:19
59fceb5 to
7367a65
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/fix-url-details-array-assertions
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:00
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-testcode-compat
branch
from
October 19, 2026 17:09
7367a65 to
1843fdb
Compare
ramonjd
approved these changes
Oct 21, 2026
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
| PR | Before (base PR) | After (this PR) | Top of stack |
|---|---|---|---|
#84419 wp/5.9 |
PHP 8.0 (earlier base run 38008683740): 13 errors, including the same 4 Navigation Link ones | PHP 8.0: 9 errors, none from Navigation Link | #85103: all 10 PHP jobs pass |
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-testcode-compat
branch
from
October 21, 2026 15:43
1843fdb to
dfb144e
Compare
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
…nk render tests.
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-testcode-compat
branch
from
October 23, 2026 13:43
dfb144e to
ee3e107
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
Saves, sets and restores
WP_Block_Supports::$block_to_renderinset_up()/tear_down()ofphpunit/class-block-library-navigation-link-test.php. Test code only.Why?
The Navigation Link tests call the block's render function directly, so
WP_Block_Supports::$block_to_renderisnullwhenget_block_wrapper_attributes()reads it. ThePHP 8.0andPHP 8.1legs reportTrying to access array offset on value of type nullinclass-wp-block-supports.php:94(4 tests). That is a notice on PHP 7 and a warning, converted to an error, on PHP 8.How?
Adapted from
wp/6.0's #84286. The navigation-link hunk is identical to #84286's; the render-last-posts part of #84286 doesn't apply because that file doesn't exist on this branch.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code