Repository navigation
Repair wp/5.9 branch Actions: Use assertString(Not)ContainsString() for string haystacks - #84416
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
This was referenced Oct 9, 2026
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/fix-phpunit-dev-dependency-floor
to
wp/5.9
October 10, 2026 00:17
desrosj
force-pushed
the
fix-actions-5.9/fix-webfonts-test-string-assertions
branch
from
October 10, 2026 00:19
9020ee7 to
0044c58
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/fix-phpunit-dev-dependency-floor
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:01
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.9/fix-webfonts-test-string-assertions
branch
from
October 19, 2026 17:09
0044c58 to
03278b5
Compare
ramonjd
approved these changes
Oct 21, 2026
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
| PR | Before (base PR) | After |
|---|---|---|
#84416 wp/5.9 (5 calls in class-block-editor-test.php, 6 in class-wp-rest-url-details-controller-test.php) |
#84415, PHP 8.0: 11 errors must be of type iterable, string given (3 block editor, 8 URL details) |
Top of stack #85103: all 10 PHP jobs pass; all 11 changed lines are still there |
desrosj
force-pushed
the
fix-actions-5.9/fix-webfonts-test-string-assertions
branch
from
October 21, 2026 15:43
03278b5 to
fd26041
Compare
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
…()` for string haystacks.
desrosj
force-pushed
the
fix-actions-5.9/fix-webfonts-test-string-assertions
branch
from
October 23, 2026 13:43
fd26041 to
9913f7e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
Replaces
assertContains()/assertNotContains()calls that use a string haystack withassertStringContainsString()/assertStringNotContainsString(). Test code only.phpunit/class-block-editor-test.php$after, the implodedwp-api-fetchinline script)phpunit/class-wp-rest-url-details-controller-test.php$data['title'])Why?
PHPUnit 9, which the
PHP 8.0andPHP 8.1legs ofunit-test.ymlrun, removed string-haystack support fromassertContains()/assertNotContains(), so these calls fail withTypeError: ... Argument #2 ($haystack) must be of type iterable, string given(3 block editor tests and 8 URL details test runs). ThePHP 7.4legs, on PHPUnit8.5.40, already warn about them.assertString*ContainsString()is available on the PHPUnit5.7and6.5legs throughyoast/phpunit-polyfills, which thewp-phpunit/wp-phpunit5.9test case uses.How?
The same problem
wp/6.0's #84284 fixes inWP_Webfonts_Test. That test doesn't exist on this branch, so this PR fixes the branch's own string-haystack calls. The two array-needleassertContains()calls in the URL details test are a different problem, fixed in #84418.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code