Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
This was referenced Oct 9, 2026
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/remove-mobile-unit-js-job
to
wp/5.9
October 10, 2026 00:17
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
October 10, 2026 00:19
d64b102 to
f20bfb2
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/remove-mobile-unit-js-job
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 00:57
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.9 branch Actions: Single Node.js version testingwp/5.9 branch Actions: Test against a single Node.js version
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
lucatume
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
Removes Node.js version matrices and hardcoded, duplicated Node version literals across every workflow in
.github/workflows/, replacing them withnode-version-file: '.nvmrc'on eachactions/setup-nodecall. No occurrence ofcheck-latest: truewas found anywhere in the tree, so there was nothing to remove for that part of this change.unit-test.ymlunit-jsnode: ['12', '14']node-version-file: '.nvmrc', no matrixunit-test.ymlunit-phpnode-version: 14node-version-file: '.nvmrc'create-block.ymlchecksnode: ['12', '14']node-version-file: '.nvmrc', no matrixend2end-test.ymladminpart: [1,2,3,4]+node: ['14']part: [1,2,3,4]only;node-version-file: '.nvmrc'bundle-size.ymlbuildnode: ['14']node-version-file: '.nvmrc', no matrixstatic-checks.ymlnode-version: 14node-version-file: '.nvmrc'This branch has no composite
.github/setup-node/action.ymlwrapper, so everyactions/setup-nodecall in every workflow file duplicated its own Node version, whether via a matrix or a hardcoded literal. All of them are updated here so.nvmrcbecomes the single source of truth, rather than only the two files (create-block.yml,unit-test.yml) that had a genuine multi-value matrix.Where a matrix combined a Node dimension with a real, non-Node dimension (
end2end-test.yml'spart), only the Node dimension was removed.Why?
This branch is frozen and will never move off the Node.js version pinned in
.nvmrc. Testing multiple Node versions (unit-test.yml,create-block.yml) added CI time without adding real coverage, and every place a Node version was hardcoded or matrixed instead of read from.nvmrcwas a place that version could silently drift from the one actually documented as required, without any workflow reflecting the change.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.