Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f1858c8 to
38e50f1
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tellthemachines. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.9 branch Actions: remove the mobile-unit-js jobwp/5.9 branch Actions: Remove the mobile-unit-js job
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM!
Are the descriptions for these PRs AI-generated? I've been noticing how they differ slightly on all the branches from 6.8 downwards while having the same info.
They are. I instructed it to use the same descriptions for each fix across every stack's corresponding PR, except when there is context specific to a given branch. It generally did an OK job, but I think that strayed a bit when I made revisions only to specific branch ranges (ie. 6.8-6.4, or something similar). |
Part of #82934.
What?
Removes the
mobile-unit-jsjob (job nameMobile) from.github/workflows/unit-test.yml.Why?
This job is not broken, and it is not disabled. Unlike the equivalent job on
wp/7.0andwp/6.9— where it carries a hardcodedif: false— this branch's copy has the ordinaryif: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}condition, runs on every push and pull request, and currently passes. It is being removed for scope and consistency, not because of a failure.The job runs the React Native mobile unit tests. On this branch it does so via
npm run native test, which resolves tonpm run --prefix packages/react-native-editor test, i.e. thereact-native-editorpackage's own Jest suite configured bytest/native/jest.config.js. (Note this is the older script form — thetest:nativeroot script that later branches invoke does not exist here.)React Native mobile support is no longer maintained or shipped as part of Gutenberg, and the bottom PR in this stack already removed the React Native workflows on that basis:
rnmobile-android-runner.ymlandrnmobile-ios-runner.ymlwere dropped as providing no signal worth spending CI resources on for a frozen, security-maintenance-only branch.mobile-unit-jsis the last remaining piece of that same testing surface still running here. Leaving it behind means this branch keeps paying runner time on every PR to test a platform it will never ship a fix for, while the E2E half of that story is already gone — an inconsistent end state.Any dangling references?
None. Nothing under
.github/referencesmobile-unit-jsin aneeds:list or anywhere else, and the job declares nooutputs. The file's remaining two jobs,unit-js(JavaScript) andunit-php(PHP), are independent and untouched; the workflow still parses with exactly those two jobs.Testing Instructions
The
Mobilecheck should no longer appear in the Unit Tests workflow run for this PR.JavaScriptand thePHP *matrix jobs should behave exactly as they do on the base branch.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code