Repository navigation
Repair wp/6.0 branch Actions: Remove the navigation menu edit permission e2e test - #84292
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
desrosj
added this pull request to stack #84293
October 8, 2026 04:34
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 8, 2026 17:35
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.0/fix-nav-edit-permission-e2e-test
branch
from
October 8, 2026 18:17
6217d20 to
9aab5c5
Compare
desrosj
removed this pull request from stack #84293
October 8, 2026 21:54
desrosj
changed the base branch from
fix-actions-6.0/skip-media-text-float-fixture-before-php-7-1
to
wp/6.0
October 8, 2026 21:56
desrosj
force-pushed
the
fix-actions-6.0/fix-nav-edit-permission-e2e-test
branch
from
October 8, 2026 21:56
9aab5c5 to
4d3f6bc
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/skip-media-text-float-fixture-before-php-7-1
October 8, 2026 21:58
desrosj
added this pull request to stack #84357
October 8, 2026 21:58
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84357
October 10, 2026 00:11
desrosj
changed the base branch from
fix-actions-6.0/skip-media-text-float-fixture-before-php-7-1
to
wp/6.0
October 10, 2026 00:12
desrosj
force-pushed
the
fix-actions-6.0/fix-nav-edit-permission-e2e-test
branch
from
October 10, 2026 00:13
4d3f6bc to
b63fd71
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/skip-media-text-float-fixture-before-php-7-1
October 10, 2026 00:16
desrosj
added this pull request to stack #84488
October 10, 2026 00:16
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-6.0/fix-nav-edit-permission-e2e-test
branch
from
October 19, 2026 17:08
b63fd71 to
8a73684
Compare
desrosj
force-pushed
the
fix-actions-6.0/fix-nav-edit-permission-e2e-test
branch
from
October 21, 2026 15:44
8a73684 to
9d401a4
Compare
desrosj
removed this pull request from stack #84488
October 21, 2026 15:57
desrosj
added this pull request to stack #85301
October 21, 2026 15:59
desrosj
removed this pull request from stack #85301
October 21, 2026 19:46
desrosj
added this pull request to stack #85348
October 21, 2026 19:46
desrosj
removed this pull request from stack #85348
October 22, 2026 17:52
desrosj
added this pull request to stack #85405
October 22, 2026 17:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82933.
What?
Removes the "Navigation › Permission based restrictions › shows a warning if user does not have permission to edit or update navigation menus" e2e test from
packages/e2e-tests/specs/editor/blocks/navigation.test.js. The other test in thatdescribeblock, for a user without permission to create navigation menus, is kept.Why?
The test fails on every run on this branch, on all 3 attempts, in "Admin - 3". It times out waiting for the "You do not have permission to edit this Menu. Any changes made will not be saved." notice.
.wp-env.jsonon this branch runs WordPress fromWordPress/WordPress#6.0-branch, which now includes the WordPress 6.0.11 security change WordPress/WordPress@80f65db ("REST API: Increase the specificity of capability checks for collections when theeditcontext is in use"). With it, a collection request made withcontext=editonly returns the posts the user can edit. The test creates a navigation menu as an Administrator, then inserts a Navigation block as a Contributor, who can read but not edit that menu. The block requests the menus withcontext=edit, so the Administrator's menu is no longer in the list, the block never selects it, and the notice the test waits for is never shown.Trunk removed this test in #41306 (10594b1), and
wp/6.1and newer don't have it. Pinning WordPress to 6.0.10 would make it pass again, but would test against a version without the 6.0.11 security fixes.How?
Deletes the test. No imports or helpers became unused.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code