Repository navigation
Repair wp/6.0 branch Actions: Use assertStringContainsString() for string haystacks - #84284
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84293
October 8, 2026 04:34
desrosj
marked this pull request as ready for review
October 8, 2026 17:37
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.0/fix-webfonts-test-string-assertions
branch
from
October 8, 2026 18:17
99d5835 to
d4ea102
Compare
desrosj
removed this pull request from stack #84293
October 8, 2026 21:54
desrosj
changed the base branch from
fix-actions-6.0/fix-latest-posts-render-test-attributes
to
wp/6.0
October 8, 2026 21:55
desrosj
force-pushed
the
fix-actions-6.0/fix-webfonts-test-string-assertions
branch
from
October 8, 2026 21:56
d4ea102 to
b850728
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-latest-posts-render-test-attributes
October 8, 2026 21:58
desrosj
added this pull request to stack #84357
October 8, 2026 21:58
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84357
October 10, 2026 00:11
desrosj
changed the base branch from
fix-actions-6.0/fix-latest-posts-render-test-attributes
to
wp/6.0
October 10, 2026 00:12
desrosj
force-pushed
the
fix-actions-6.0/fix-webfonts-test-string-assertions
branch
from
October 10, 2026 00:13
b850728 to
58f32eb
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-latest-posts-render-test-attributes
October 10, 2026 00:15
desrosj
added this pull request to stack #84488
October 10, 2026 00:16
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
desrosj
changed the title
wp/6.0 branch Actions: Use assertStringContainsString() in WP_Webfonts_Testwp/6.0 branch Actions: Use assertStringContainsString() for string haystacks
desrosj
force-pushed
the
fix-actions-6.0/fix-webfonts-test-string-assertions
branch
from
October 19, 2026 17:08
58f32eb to
4c47f71
Compare
ramonjd
approved these changes
Oct 21, 2026
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
| PR | Before (base PR) | After |
|---|---|---|
#84284 wp/6.0 (2 calls in class-wp-webfonts-test.php) |
#84283, PHP 8.1: both WP_Webfonts_Test tests error with assertContains(): Argument #2 ($haystack) must be of type Traversable|array |
Top of stack #85149: all 10 PHP jobs pass; the webfonts test file is unchanged from this PR |
desrosj
force-pushed
the
fix-actions-6.0/fix-webfonts-test-string-assertions
branch
from
October 21, 2026 15:44
4c47f71 to
471efe3
Compare
desrosj
removed this pull request from stack #84488
October 21, 2026 15:57
desrosj
added this pull request to stack #85301
October 21, 2026 15:59
desrosj
removed this pull request from stack #85301
October 21, 2026 19:46
desrosj
added this pull request to stack #85348
October 21, 2026 19:46
desrosj
removed this pull request from stack #85348
October 22, 2026 17:52
desrosj
added this pull request to stack #85405
October 22, 2026 17:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82933.
What?
Replaces two
assertContains()calls that use a string haystack withassertStringContainsString()inphpunit/class-wp-webfonts-test.php(test_generate_and_enqueue_stylesandtest_generate_and_enqueue_editor_styles).Why?
assertContains()with a string haystack was deprecated in PHPUnit 7.5 and removed in PHPUnit 9, where it throws aTypeError, so both tests error on the8.0/8.1legs.yoast/phpunit-polyfills(already a dependency and wired into the test case base class) providesassertStringContainsString()on the older PHPUnit versions the5.6/7.0legs run.wp/6.1's copy of this test already uses it.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code