Repository navigation
Repair wp/6.0 branch Actions: Pin phpunit/phpunit to a PHP 5.6/7.0-compatible release - #84281
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
63385a3 to
d07c317
Compare
d07c317 to
7ce6df4
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
7ce6df4 to
d0ca01a
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
wp/6.0 branch Actions: pin phpunit/phpunit to a PHP 5.6/7.0-compatible releasewp/6.0 branch Actions: Pin phpunit/phpunit to a PHP 5.6/7.0-compatible release
d0ca01a to
1112ac3
Compare
1112ac3 to
3a316b5
Compare
Part of #82933.
What?
Constrains the
phpunit/phpunitdev dependency to^5.7so thePHP 5.6unit test jobs (single site and multisite) can run.Why?
Both
PHP 5.6jobs fail before any test runs with:wp-phpunit/wp-phpunitchecks the running PHPUnit version withclass_exists( 'PHPUnit\Runner\Version' ). That makes Composer's autoloader load the class from this plugin's lockedphpunit/phpunit(^8.5, which requires PHP 7.2+). PHPUnit 8.5'sRunner/Version.phpuses return type declarations, which PHP 5.6 cannot parse. PHP 7.0 supports that syntax, so only thePHP 5.6jobs are affected.How?
phpunit/phpunitto^5.7incomposer.json. This resolves to 5.7.27, the newest 5.7 release, which supports PHP 5.6 and 7.0 and still satisfieswp-phpunit/wp-phpunit's>=5.7.21requirement. PHPUnit 5.7 has noPHPUnit\Runner\Versionclass, soclass_exists()returnsfalsewithout parsing anything andwp-phpunitfalls back to its legacy version check.composer.lock.phpunit/phpunitand its dependencies move to their 5.7 versions, andsymfony/yamlv4.4.45 is added, because PHPUnit 5.7 requires it. Repairwp/6.0branch Actions: Resolve Composer dependencies against the lowest tested PHP version #84282, directly above, resolves it to a release that PHP 5.6 and 7.0 can load.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.