Repository navigation
Repair wp/6.0 branch Actions: Ignore empty PHP files in the PHP coding standards scan - #84278
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
244164e to
6bf98f9
Compare
6bf98f9 to
23ca731
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
23ca731 to
2f4352d
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
wp/6.0 branch Actions: ignore empty PHP files in the PHP coding standards scanwp/6.0 branch Actions: Ignore empty PHP files in the PHP coding standards scan
2f4352d to
6a7d432
Compare
6a7d432 to
9e02fa9
Compare
Part of #82933.
What?
Keeps the
Unit Tests→PHP coding standardsjob from failing on a deliberately empty placeholder file underpackages/e2e-tests/themes.Why?
packages/e2e-tests/themes/style-variations/index.phpis an intentionally empty placeholder — the standard WordPress convention for blocking a directory listing. PHP_CodeSniffer'sInternal.NoCodeFoundcheck reports any file containing no PHP code as a warning, andphpcsexits non-zero as soon as any warning is reported. That single file is therefore enough to fail the scan even when there is not one real coding-standards issue anywhere else in the codebase.How?
phpcs.xml.dist: ports trunk's existingInternal.NoCodeFoundexclusion. Trunk excludes its own test-theme fixture directory (/test/gutenberg-test-themes/*); this branch's equivalent fixture directory ispackages/e2e-tests/themes/*.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.