Repository navigation
Repair wp/6.0 branch Actions: Fix Playwright browser-install failures on Ubuntu 24.04 - #84276
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ec00719 to
e1abcd5
Compare
e1abcd5 to
47bf18a
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
47bf18a to
7977cd1
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
wp/6.0 branch Actions: fix Playwright browser-install failures on Ubuntu 24.04 (Noble)wp/6.0 branch Actions: Fix Playwright browser-install failures on Ubuntu 24.04
7977cd1 to
6df9e28
Compare
6df9e28 to
447cb81
Compare
Part of #82933.
What?
Fixes the browser-install failure in
end2end-test-playwright.yml'sE2E Testsjob onubuntu-24.04, so the job reaches its tests instead of failing atInstall Playwright dependencies.Why?
GitHub's
ubuntu-24.04runner label now resolves to Ubuntu 24.04 "Noble". Playwright1.20.0(pinned in this branch'spackage.json) predates Noble's addition to Playwright's bundled OS-dependency lookup table, sonpx playwright install chromium --with-deps's own OS-detection step fails outright, before a single browser binary is even downloaded.This branch's
.nvmrcpins Node14— no headroom to bump@playwright/testto a version that recognizes Noble natively. So this decouples the browser-binary download from the system-library install: replace--with-depswith a plain binary-onlyplaywright install.This branch's own
test/e2e/playwright.config.tsdefines only a singlechromiumproject — there's no Firefox or WebKit leg to worry about here at all. Chromium needs no additional system packages on Noble beyond what the base runner image already provides, so this fix is a plain one-line change (drop--with-deps) with no accompanyingapt-getstep required.How?
.github/workflows/end2end-test-playwright.yml'se2ejob'sInstall Playwright dependenciesstep changes fromnpx playwright install chromium --with-depstonpx playwright install chromium(renamed toInstall Playwright browser binariesto match).Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.