Repository navigation
Repair wp/6.1 branch Actions: Replace wp-env's database check with a MariaDB health check - #84260
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
79b3302 to
a7b8354
Compare
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
a7b8354 to
540b2e8
Compare
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
540b2e8 to
d86c87b
Compare
Part of #82932.
What?
Ports #75046 to this branch's
wp-env: replaces thewp db checkwait inwp-env startwith a Docker health check on the MariaDB services, and makes WordPress wait for it (depends_on: condition: service_healthy).Why?
The next PR in this stack, #84259, pins MariaDB
10.6. The MariaDB 11.8 client in the currentwordpress:cliimage requires TLS, which MariaDB before 11.4 doesn't offer, so without this changewp db checkwould fail with "SSL is required, but the server does not support it" and every job that startswp-envwould fail. Trunk removedwp db checkin #75046; a health check doesn't use the MySQL client.How?
depends_on,startandcleanfollow wp-env: Fix MySQL startup race condition causing database connection errors #75046, adapted to this branch's file layout.healthcheck.shonly when the image and data volume support it, and otherwise pings MariaDB withmariadb-adminormysqladmin, so older images (10.2/10.3, and tags without the script) still become healthy. Unlikewp/6.3and newer, this branch'swp-envuses the stockwordpress:cliimage without a generated Dockerfile, so Env: Add an option to choose the MariaDB version #83751's client wrappers can't be added;wp dbcommands still fail below 11.4, as the README notes..split().join()instead ofreplaceAllfor Node 14. The changelog and README note are updated.Verified locally:
wp-env startworks with MariaDB10.6and10.3.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.