Repository navigation
Repair wp/6.1 branch Actions: Fix ReflectionException on PHP 5.6/7.0 in block-pattern REST tests - #84257
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84262
October 8, 2026 03:56
This was referenced Oct 8, 2026
desrosj
marked this pull request as ready for review
October 8, 2026 17:27
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84262
October 8, 2026 21:51
desrosj
changed the base branch from
fix-actions-6.1/allow-php-deprecation-notices-in-phpunit
to
wp/6.1
October 8, 2026 21:52
desrosj
force-pushed
the
fix-actions-6.1/fix-reflection-getstaticpropertyvalue-php7
branch
from
October 8, 2026 21:52
95dd711 to
01317d7
Compare
desrosj
changed the base branch from
wp/6.1
to
fix-actions-6.1/allow-php-deprecation-notices-in-phpunit
October 8, 2026 21:53
desrosj
added this pull request to stack #84356
October 8, 2026 21:54
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84356
October 10, 2026 00:07
desrosj
changed the base branch from
fix-actions-6.1/allow-php-deprecation-notices-in-phpunit
to
wp/6.1
October 10, 2026 00:08
desrosj
force-pushed
the
fix-actions-6.1/fix-reflection-getstaticpropertyvalue-php7
branch
from
October 10, 2026 00:09
01317d7 to
5de9721
Compare
desrosj
changed the base branch from
wp/6.1
to
fix-actions-6.1/allow-php-deprecation-notices-in-phpunit
October 10, 2026 00:10
desrosj
added this pull request to stack #84486
October 10, 2026 00:11
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
…ass::getStaticPropertyValue()/setStaticPropertyValue().
desrosj
force-pushed
the
fix-actions-6.1/fix-reflection-getstaticpropertyvalue-php7
branch
from
October 19, 2026 17:08
5de9721 to
b8f2e7f
Compare
desrosj
removed this pull request from stack #84486
October 21, 2026 19:45
desrosj
added this pull request to stack #85346
October 21, 2026 19:46
ramonjd
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82932.
What?
In the block pattern and block pattern category REST controller tests, uses
ReflectionProperty::getValue()andsetValue()instead ofReflectionClass::getStaticPropertyValue()andsetStaticPropertyValue()to swap each registry's private static$instanceduring setup and teardown.Why?
On PHP 5.6 and 7.0,
getStaticPropertyValue()andsetStaticPropertyValue()ignoresetAccessible( true )for private properties and throwReflectionException: Class WP_Block_Patterns_Registry does not have a property named instance(and the same forWP_Block_Pattern_Categories_Registry). That causes 18 errors in each PHP 5.6 and 7.0 job. PHP 7.4 and newer aren't affected.Use of AI Tools
This PR was authored with the help of Claude Code, including live reproduction and verification against real PHP 5.6/7.0 interpreters and a real wp-env-managed WordPress installation (not log analysis alone).