Repository navigation
Repair wp/6.1 branch Actions: Fix theme-activation navigation race in activate-theme.js - #84255
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84262
October 8, 2026 03:56
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 8, 2026 16:31
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84262
October 8, 2026 21:51
desrosj
changed the base branch from
fix-actions-6.1/fix-playwright-noble-install
to
wp/6.1
October 8, 2026 21:52
desrosj
force-pushed
the
fix-actions-6.1/fix-activate-theme-navigation-race
branch
from
October 8, 2026 21:52
4f9a442 to
b2bcc66
Compare
desrosj
changed the base branch from
wp/6.1
to
fix-actions-6.1/fix-playwright-noble-install
October 8, 2026 21:53
desrosj
added this pull request to stack #84356
October 8, 2026 21:54
desrosj
removed this pull request from stack #84356
October 10, 2026 00:07
desrosj
changed the base branch from
fix-actions-6.1/fix-playwright-noble-install
to
wp/6.1
October 10, 2026 00:08
desrosj
force-pushed
the
fix-actions-6.1/fix-activate-theme-navigation-race
branch
from
October 10, 2026 00:09
b2bcc66 to
f05657f
Compare
desrosj
changed the base branch from
wp/6.1
to
fix-actions-6.1/fix-playwright-noble-install
October 10, 2026 00:10
desrosj
added this pull request to stack #84486
October 10, 2026 00:11
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-6.1/fix-activate-theme-navigation-race
branch
from
October 19, 2026 17:08
f05657f to
699dcbc
Compare
desrosj
removed this pull request from stack #84486
October 21, 2026 19:45
desrosj
added this pull request to stack #85346
October 21, 2026 19:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82932.
What?
Fixes a theme-activation navigation race in
packages/e2e-test-utils/src/activate-theme.js'sactivateTheme()helper, used by the Puppeteer end-to-end suite (including the sharedconfig/setup-test-framework.jssetup, which activates a theme before each spec file).activateTheme()clicks the "Activate" link onwp-admin/themes.php, then immediately callspage.waitForSelector()with Puppeteer's default 30s timeout to confirm the theme became active. This PR wraps the click inPromise.all()withpage.waitForNavigation( { waitUntil: 'networkidle0' } ), and gives the finalwaitForSelector()an explicit 45s timeout.Why?
The "Activate" link is a plain link: clicking it triggers a real, full-page navigation (
switch_theme()on the server, then a redirect back tothemes.php). Without waiting for that navigation, the singlewaitForSelector()that follows has to cover the whole click → theme switch → redirect → page reload chain by itself, which can time out with:On
wp/6.5andwp/6.4this race failed the Puppeteer suite in CI repeatedly (onwp/6.4, 20 of 114 failed end-to-end runs without the fix hit it; 0 of 49 with it), and it is fixed there by #83002 and #83686. This branch has the same race in an older form of the helper, but it has not been seen to fail here: none of the 20 most recent failed end-to-end runs on this branch's stack hit it. It is included proactively, so the helper behaves the same across branches and a future failure here does not have to be investigated from scratch.The code is the same as on
wp/6.5andwp/6.4, includingwaitUntil: 'networkidle0'. This branch'slogin-user.jswaits for its own submit navigation with a plainpage.waitForNavigation(); the same form as the other branches' fix is used here so the helper is identical everywhere. The "theme is already active" early return is unchanged.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code