Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…ys use the workflow file from trunk, so this branch's copy never runs.
5b2e781 to
be823d7
Compare
| npm run build:packages | ||
|
|
||
| - name: Report flaky tests | ||
| uses: ./packages/report-flaky-tests |
There was a problem hiding this comment.
With this workflow gone, nothing on wp/6.1 reads the flaky-tests-report* artifacts. The e2e workflows still produce them, and those upload steps pin actions/upload-artifact@e448a9b (v2.2.2). GitHub fails any job using it before it starts, which is why E2E Tests dies in 2s (log: "automatically failed because it uses a deprecated version of actions/upload-artifact").
Suggest removing the producer steps in this PR:
.github/workflows/end2end-test.yml L59-65, delete:
- name: Archive flaky tests report
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
if: always()
with:
name: flaky-tests-report-${{ matrix.part }}
path: flaky-tests
if-no-files-found: ignore.github/workflows/end2end-test-playwright.yml L60-66, delete:
- name: Archive flaky tests report
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
if: always()
with:
name: flaky-tests-report-playwright
path: flaky-tests
if-no-files-found: ignoreThe failure-artifact upload step in each file pins the same deprecated version, so e2e still needs that bump to go green.
Optional, the reporters that write those files:
packages/e2e-tests/jest.config.jsL23-24: drop the comment andprocess.env.CI && '<rootDir>/config/flaky-tests-reporter.js',, then deletepackages/e2e-tests/config/flaky-tests-reporter.js.test/e2e/playwright.config.tsL15:? [ [ 'github' ], [ './config/flaky-tests-reporter.ts' ] ]→? 'github', then deletetest/e2e/config/flaky-tests-reporter.ts.packages/report-flaky-tests(the action this workflow ran), pluspackage.jsonL157,tsconfig.jsonL35 and thepackage-lock.jsonentry.- Stale references:
packages/e2e-tests/config/setup-test-framework.jsL73-74 comment,docs/contributors/code/testing-overview.mdL578. The retry logic insetup-test-framework.jsis still useful without the reporter.
There was a problem hiding this comment.
@lucatume I noted over on #84395, but I've gone and applied all of the changes that can be made without requiring an npm package to be published (which I'd like to avoid as much as possible).
For the actions/upload-artifacg, that is addressed further up the stack in #84242 where all GitHub Actions are updated to their latest versions.
Part of #82932.
What?
Removes GitHub Actions workflow files from
wp/6.1that can never run correctly from this branch, that can never run at all as this branch's copy because of GitHub's own event-triggering rules, or that are only maintained for the current WordPress release.rnmobile-ios-runner.ymlmacos-11, a runner image GitHub retired in June 2023; the job can no longer executernmobile-android-runner.ymlstorybook-pages.ymltrunk; this branch never pushes totrunkupload-release-to-plugin-repo.ymlreleaseevent; releases are cut fromtrunk, not from frozenwp/X.Ybranchesstale-issue-add-needs-testing.yml,stale-issue-flaky-test.yml,stale-issue-mark-stale.yml,stale-issue-needs-info.ymlschedule; GitHub Actions always uses the default branch's copy of a scheduled workflow, never this branch'sflaky-tests.ymlworkflow_run; likeschedule, GitHub Actions always uses the default branch's copy, never this branch'sperformance.ymlpull-request-automation.ymlpull_request_targetruns always use trunk's copy of the file, and itspush-triggered tasks return immediately outsidetrunk, so this branch's copy never does anythingbuild-plugin-zip.ymllatestpublish)trunkor arelease/*branch, so they never run fromwp/6.1publish-npm-packages.ymlis kept: it is manually dispatched only, and both of its checkout steps hard-coderef: trunk, so it can never publish from this branch.Why?
Keeping dead workflow files around on a frozen maintenance branch adds noise to the Actions tab and confusion for anyone trying to understand what actually runs against
wp/6.1. Apart from the performance tests, which are only maintained for the current WordPress release, none of the removed files can produce a passing (or in most cases, any) run from this branch's copy, so removing them has no effect on real CI coverage.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.