Repository navigation
Repair wp/6.2 branch Actions: Migrate the Query block e2e test to Playwright - #84237
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84239
October 8, 2026 03:30
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 8, 2026 14:46
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84239
October 8, 2026 21:47
desrosj
changed the base branch from
fix-actions-6.2/fix-flaky-site-editor-url-navigation
to
wp/6.2
October 8, 2026 21:48
desrosj
force-pushed
the
fix-actions-6.2/migrate-query-test-to-playwright
branch
from
October 8, 2026 21:49
07602fa to
96efc51
Compare
desrosj
changed the base branch from
wp/6.2
to
fix-actions-6.2/fix-flaky-site-editor-url-navigation
October 8, 2026 21:50
desrosj
added this pull request to stack #84355
October 8, 2026 21:50
desrosj
removed this pull request from stack #84355
October 10, 2026 00:03
desrosj
changed the base branch from
fix-actions-6.2/fix-flaky-site-editor-url-navigation
to
wp/6.2
October 10, 2026 00:04
desrosj
force-pushed
the
fix-actions-6.2/migrate-query-test-to-playwright
branch
from
October 10, 2026 00:05
96efc51 to
73d43da
Compare
desrosj
changed the base branch from
wp/6.2
to
fix-actions-6.2/fix-flaky-site-editor-url-navigation
October 10, 2026 00:07
desrosj
added this pull request to stack #84484
October 10, 2026 00:07
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
tellthemachines
approved these changes
Oct 19, 2026
desrosj
added
the
props-bot
github-actions
Bot
removed
the
props-bot
desrosj
removed this pull request from stack #84484
October 21, 2026 19:44
desrosj
added this pull request to stack #85344
October 21, 2026 19:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82931.
What?
Backports #47995, which replaces the Puppeteer
packages/e2e-tests/specs/editor/blocks/query.test.jswith a Playwrighttest/e2e/specs/editor/blocks/query.spec.js, and adds therequestUtils.deleteAllPages()helper it uses.Why?
Query block › Query block insertion › ListfailedPuppeteer - 1on all three Jest attempts:The failure screenshots show the "Choose a pattern" modal closed and the Query Loop block still in its placeholder state, so the "Standard" pattern was never applied. The Puppeteer test clicks the pattern with an un-awaited
chosenPattern.click(), which clicks at the element's screen coordinates, and then waits for a rendered post date. If the pattern list's layout shifts while its previews load, the click can miss the pattern and the modal closes without inserting it.The Playwright version avoids both: its clicks wait for the element to be visible and stable, and it checks the inserted block tree (
editor.getBlocks()) instead of waiting for posts to render. Trunk never fixed the Puppeteer test; it was replaced by this migration shortly afterwp/6.2was cut.How?
Cherry-pick of 1e9c93b. One conflict, in
packages/e2e-test-utils-playwright/src/request-utils/index.ts: this branch doesn't have trunk's./menusimport, so only the newimport { deleteAllPages } from './pages';line is added. The other files apply unchanged. Every other Playwright helper the new test uses (editor.insertBlock(),editor.canvas,editor.getBlocks(),requestUtils.activatePlugin(),createPost(),deleteAllPosts()) already exists on this branch.wp/6.3and newer already have the Playwright test.wp/6.1,wp/6.0andwp/5.9have an older Puppeteer version with a different pattern modal, but no failures of it were found in their CI, so it is not backported there.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code