Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84239
October 8, 2026 03:30
desrosj
marked this pull request as ready for review
October 8, 2026 14:45
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84239
October 8, 2026 21:47
desrosj
changed the base branch from
fix-actions-6.2/add-mariadb-version-option
to
wp/6.2
October 8, 2026 21:48
desrosj
force-pushed
the
fix-actions-6.2/detect-db-client-in-debug-step
branch
from
October 8, 2026 21:49
119e3f4 to
4472f09
Compare
desrosj
changed the base branch from
wp/6.2
to
fix-actions-6.2/add-mariadb-version-option
October 8, 2026 21:50
desrosj
added this pull request to stack #84355
October 8, 2026 21:50
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84355
October 10, 2026 00:03
desrosj
changed the base branch from
fix-actions-6.2/add-mariadb-version-option
to
wp/6.2
October 10, 2026 00:04
desrosj
force-pushed
the
fix-actions-6.2/detect-db-client-in-debug-step
branch
from
October 10, 2026 00:05
4472f09 to
90970e7
Compare
desrosj
changed the base branch from
wp/6.2
to
fix-actions-6.2/add-mariadb-version-option
October 10, 2026 00:07
desrosj
added this pull request to stack #84484
October 10, 2026 00:07
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84484
October 21, 2026 19:44
desrosj
added this pull request to stack #85344
October 21, 2026 19:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82931.
What?
Makes the database line of
unit-test.yml's "Docker container debug information" step work with any MySQL or MariaDB version. It now runsmariadb --versionwhen the database container has amariadbclient, andmysql --versionwhen it doesn't.Why?
The client's name depends on the database version, and this branch supports MySQL and MariaDB back to 5.5:
mysql.mariadb: themysqlalias was removed.A fixed name fails on part of that range, so the step checks which client exists before running it. WordPress Core's test environment makes the same distinction by version (WordPress/wordpress-develop@ea80ac8).
How?
The line runs a short
sh -cscript inside thetests-mysqlcontainer. This branch'swp-envpasses aruncommand to the host shell as a single line, so the script is wrapped in single quotes inside the command string to reach the container intact.Tested this branch's
wp-env runargument handling (Node.js 14, npm 6) against MariaDB 5.5, 10.3, 10.11 and 13.0 and MySQL 5.7 and 8.4: each prints its client version and exits successfully.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.