Repository navigation
Meta Boxes: Don't render an empty panel when only side boxes exist - #84196
Closed
snehapatil2001 wants to merge 2 commits into
Closed
snehapatil2001 wants to merge 2 commits into
snehapatil2001 wants to merge 2 commits into
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
Contributor
|
Hi @snehapatil2001, thanks for your contribution. I don't think this is the ideal approach, so I'm going to close this issue. Please see #84173 (comment) for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #84173.
Stops the editor from rendering an empty "Meta Boxes" panel when the only registered meta boxes are in the
sidelocation.Why?
MetaBoxesMaindecided whether to show the bottom panel by checking thenormal,advancedandsidelocations. The panel body only rendersnormalandadvanced, becausesidemeta boxes are rendered separately in the sidebar. A site with onlysidemeta boxes therefore got the "Meta Boxes" toggle bar and a drag handle with nothing inside.How?
Removes
isMetaBoxLocationVisible( 'side' )from thehasAnyVisiblecondition inMetaBoxesMain(packages/edit-post/src/components/layout/index.jsx), so the panel only shows whennormaloradvancedhas meta boxes. Adds a changelog entry for@wordpress/edit-post.Testing Instructions
sidecontext only, for exampleadd_meta_box( 'repro', 'Repro', $callback, 'post', 'side' ). Make sure Screen Options → Custom Fields is unchecked, since that adds anormalbox.normaloradvanced. The "Meta Boxes" panel should appear and work as before.Testing Instructions for Keyboard
sidemeta box registered, press Tab through the editor. Focus should never land on a "Meta Boxes" toggle button at the bottom.normaloradvancedmeta box registered, the "Meta Boxes" toggle should be reachable with Tab and open or close with Enter or Space.