Repository navigation
Repair wp/6.9 branch Actions: Disable the node_modules cache in the Storybook check - #84180
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83631
October 7, 2026 16:02
This was referenced Oct 7, 2026
desrosj
marked this pull request as ready for review
October 7, 2026 16:13
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #83631
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-router-styles-refresh-test
to
wp/6.9
October 7, 2026 18:15
desrosj
force-pushed
the
fix-actions-6.9/disable-node-modules-cache-in-storybook-check
branch
from
October 7, 2026 18:16
75207fe to
197706d
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-router-styles-refresh-test
October 7, 2026 18:19
desrosj
added this pull request to stack #84190
October 7, 2026 18:19
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84190
October 8, 2026 21:14
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-router-styles-refresh-test
to
wp/6.9
October 8, 2026 21:15
desrosj
force-pushed
the
fix-actions-6.9/disable-node-modules-cache-in-storybook-check
branch
from
October 8, 2026 21:16
197706d to
ef68765
Compare
github-actions
Bot
added
[Tool] Env
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-router-styles-refresh-test
October 8, 2026 21:18
desrosj
added this pull request to stack #84348
October 8, 2026 21:18
desrosj
removed this pull request from stack #84348
October 9, 2026 23:31
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-router-styles-refresh-test
to
wp/6.9
October 9, 2026 23:32
desrosj
force-pushed
the
fix-actions-6.9/disable-node-modules-cache-in-storybook-check
branch
from
October 9, 2026 23:33
ef68765 to
208a01d
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-router-styles-refresh-test
October 9, 2026 23:35
desrosj
added this pull request to stack #84470
October 9, 2026 23:35
desrosj
force-pushed
the
fix-actions-6.9/disable-node-modules-cache-in-storybook-check
branch
from
October 19, 2026 17:05
208a01d to
8ac1983
Compare
desrosj
removed this pull request from stack #84470
October 21, 2026 18:33
desrosj
added this pull request to stack #85323
October 21, 2026 18:34
andrewserong
approved these changes
Oct 22, 2026
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
This looks nice and simple, and skipping the Cache node_modules step via cache: false sounds good to me 👍
desrosj
force-pushed
the
fix-actions-6.9/disable-node-modules-cache-in-storybook-check
branch
from
October 23, 2026 18:20
8ac1983 to
f055c34
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Sets
cache: falseon the./.github/setup-nodestep in the Storybook check workflow (.github/workflows/storybook-check.yml), so the job neither restores nor saves thenode_modulesand npm caches.Why?
The Storybook check runs
./.github/setup-node, then runsnpm install --no-save @storybook/test-runner@..., which adds and changes packages insidenode_modules. At the end of the job, thenode_modulescache step saves that modified tree. Its cache key only covers the OS, architecture, Node.js version and lockfile hash, so the modified tree is saved as if it were a clean install. Later jobs on the same ref restore it, skipnpm ci, and fail.For example, on #84039 the Storybook check (https://github.com/WordPress/gutenberg/actions/runs/37631035082) saved the cache after
npm install --no-savereported "added 101 packages, changed 29 packages". The Unit Tests run (https://github.com/WordPress/gutenberg/actions/runs/37631034438) restored it a few minutes later, and "Build JavaScript assets for PHP unit tests" failed withTS2307: Cannot find module 'http'and other missing Node.js type errors.How?
Uses the
cacheinput that #83402 adds to.github/setup-node/action.ymlon this branch. Withcache: false, the Storybook check always runs a freshnpm ciand never writes its modifiednode_modulesback to the shared cache.Trunk fixed this differently in b7fb03b, which removed the
npm install --no-savestep. That change depends on astorybookworkspace that this branch does not have.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code