Repository navigation
Repair wp/6.9 branch Actions: Fix flaky router styles stylesheet-failure e2e test - #84177
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 7, 2026 15:57
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-router-styles-refresh-test
branch
from
October 7, 2026 16:00
2e1ce96 to
f7bb376
Compare
desrosj
removed this pull request from stack #83631
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.9
October 7, 2026 18:15
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-router-styles-refresh-test
branch
from
October 7, 2026 18:16
f7bb376 to
b7f3daf
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-openverse-image-drag-and-drop-test
October 7, 2026 18:19
desrosj
added this pull request to stack #84190
October 7, 2026 18:19
desrosj
removed this pull request from stack #84190
October 8, 2026 21:14
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.9
October 8, 2026 21:15
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-router-styles-refresh-test
branch
from
October 8, 2026 21:16
b7f3daf to
2e264d8
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-openverse-image-drag-and-drop-test
October 8, 2026 21:18
desrosj
added this pull request to stack #84348
October 8, 2026 21:18
desrosj
removed this pull request from stack #84348
October 9, 2026 23:31
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.9
October 9, 2026 23:32
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-router-styles-refresh-test
branch
from
October 9, 2026 23:33
2e264d8 to
76d663f
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-openverse-image-drag-and-drop-test
October 9, 2026 23:35
desrosj
added this pull request to stack #84470
October 9, 2026 23:35
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-router-styles-refresh-test
branch
from
October 19, 2026 17:05
76d663f to
8a5afec
Compare
desrosj
removed this pull request from stack #84470
October 21, 2026 18:33
desrosj
added this pull request to stack #85323
October 21, 2026 18:34
tellthemachines
approved these changes
Oct 23, 2026
tellthemachines
left a comment
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Changeset is same as #72783 and test is passing.
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-router-styles-refresh-test
branch
from
October 23, 2026 18:20
8a5afec to
d66e524
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Backports #72783 to
wp/6.9to fix the flaky "Router styles › should refresh the page when stylesheet loading fails" e2e test intest/e2e/specs/interactivity/router-styles.spec.ts. It changes 3 files:test/e2e/specs/interactivity/router-styles.spec.ts: the route handler for the red stylesheet now aborts only the first request (tracked with aninterceptedvariable) and lets later requests continue, instead of callingpage.unrouteAll()from inside the handler while the request is in flight. The route is removed withpage.unroute()at the end of the test.packages/e2e-tests/plugins/interactive-blocks/router-styles-wrapper/render.php: the "Hydrated" marker now waits for actual hydration, bindinghiddento!state.hydratedand setting that state through adata-wp-init="callbacks.setHydrated"callback.packages/e2e-tests/plugins/interactive-blocks/router-styles-wrapper/view.js: adds thehydratedstate and thesetHydratedcallback, and wraps thenavigateaction inwithSyncEventbecause it callse.preventDefault().Why?
The test fails intermittently on the
wp/6.9stack. In https://github.com/WordPress/gutenberg/actions/runs/37631034461 (job "Playwright - 7") it failed on every retry atrouter-styles.spec.ts:316, expecting colorrgb(255, 0, 0)but receivingrgb(160, 12, 60). In the same push it was reported as flaky (passed on retry) in 5 other 6.9 PR runs.wp/7.0andwp/7.1already include #72783 in the branch itself, andwp/6.8and older do not haverouter-styles.spec.ts, sowp/6.9is the only branch that needs this backport.How?
A straight cherry-pick of 5a899df from trunk. It applied cleanly, and
@wordpress/interactivityon this branch already exportswithSyncEvent.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code