Skip to content

Editor: Validate parent container when converting blocks to template parts #84155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Oct 7, 2026
Merged

Editor: Validate parent container when converting blocks to template parts #84155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356f009
Editor: Validate parent container when converting blocks to template …
CookieDarb Oct 6, 2026
b8e9c36
Editor: Derive clientId outside useSelect in ConvertToTemplatePart
CookieDarb Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/template-part/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const init = () => {
return false;
}
}
return true;
return canInsert;

@Mamaduka Mamaduka Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I couldn't find any reason why this returned true instead of canInsert.

}
);

Expand Down
29 changes: 20 additions & 9 deletions packages/editor/src/components/template-part-menu-items/convert-to-template-part.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,27 @@ export default function ConvertToTemplatePart( { clientIds, blocks } ) {
const { replaceBlocks } = useDispatch( blockEditorStore );
const { createSuccessNotice } = useDispatch( noticesStore );

const { isBlockBasedTheme, canCreate } = useSelect( ( select ) => {
return {
isBlockBasedTheme:
select( coreStore ).getCurrentTheme()?.is_block_theme,
canCreate:
select( blockEditorStore ).canInsertBlockType(
'core/template-part'
const clientId = clientIds?.[ 0 ];
const { isBlockBasedTheme, canCreate } = useSelect(
( select ) => {
const { getBlockRootClientId, canInsertBlockType } =
select( blockEditorStore );

const rootClientId = clientId
? getBlockRootClientId( clientId )
: undefined;

return {
isBlockBasedTheme:
select( coreStore ).getCurrentTheme()?.is_block_theme,
canCreate: canInsertBlockType(
'core/template-part',
rootClientId
),
};
}, [] );
};
},
[ clientId ]
);

if ( ! isBlockBasedTheme || ! canCreate ) {
return null;
Expand Down
Loading