Skip to content

Style states: fix exception when there's no selected block #84140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 4 commits into from
Oct 7, 2026
Merged

Style states: fix exception when there's no selected block #84140

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f010783
Block editor: Prevent getSelectedBlockStyleState selector from throwi…
talldan Oct 7, 2026
9af5c35
Avoid passing `undefined` to selector
talldan Oct 7, 2026
9234e95
Add unit test
talldan Oct 7, 2026
5613ac2
changelog
talldan Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
changelog
  • Loading branch information
@talldan
talldan committed Oct 7, 2026
commit 5613ac2e5d1e515229d72f93c2e140ca81282828
1 change: 1 addition & 0 deletions packages/block-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- `BlockCompare`: Show whitespace differences in the Resolve Block dialog. The markup's spaces and blank lines are kept instead of collapsed by the browser, and each added or removed line break gets a visible marker, so a diff made only of whitespace no longer looks identical on both sides. The dialog also shows the markup of a converted Custom HTML block, which is kept in its `innerContent` rather than produced by `save`, instead of an empty diff ([#82397](https://github.com/WordPress/gutenberg/pull/82397)).
- Inserter: Stop re-rendering the block list when the block selection changes while the inserter is open ([#83284](https://github.com/WordPress/gutenberg/pull/83284)).
- Fix style edits applied to a multi-block selection overwriting each block's other styles. Only the changed values are now applied to every selected block, so distinct styles are preserved and resets propagate to the whole selection ([#80070](https://github.com/WordPress/gutenberg/pull/80070)).
- Fix exception thrown by `getSelectedBlockStyleState` when an `undefined` `clientId` is passed as an argument. ([#84140](https://github.com/WordPress/gutenberg/pull/84140))

### Internal

Expand Down
Loading