Skip to content

Icons: Add new form based icons. - #84074

Merged
andrewserong merged 3 commits into
trunkfrom
add/form-icons
Oct 21, 2026
Merged

andrewserong merged 3 commits into
trunkfrom
add/form-icons

Conversation

@jasmussen

@jasmussen jasmussen commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What?

Related to #81645 (comment). Adds 2 new form based icons:

Form controls
  • Form input
  • Form select

For "form button" we reuse the existing Button icon.

This is because all three get styleable as elements soon.

Testing Instructions

npm run storybook:dev

Use of AI Tools

Opus 5 for normalisation.

@jasmussen
jasmussen requested a review from a team October 5, 2026 10:15
@jasmussen jasmussen self-assigned this Oct 5, 2026
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Package] Icons /packages/icons labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 8875852 trunk % Change
timeToFirstByte 42.95 ms +6.52% -2.91% 43.1 ms +14.04% -4.29% -0.35%
largestContentfulPaint 72 ms +5.56% -5.56% 72 ms +8.33% -5.56% 0%
lcpMinusTtfb 28.25 ms +11.15% -5.13% 28.3 ms +15.19% -6.89% -0.18%
wpBeforeTemplate 22.42 ms +8.16% -1.83% 22.58 ms +15.5% -3.9% -0.71%
wpTemplate 16.89 ms +5.33% -4.09% 17.24 ms +1.28% -5.51% -2.03%
wpTotal 39.48 ms +7.52% -2.33% 39.75 ms +14.44% -4.55% -0.68%
wpMemoryUsage 7.66 MB +0% -0% 7.63 MB +0% -0% 0.43%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 8875852 trunk % Change
timeToFirstByte 35.1 ms +5.84% -1.28% 36.25 ms +6.48% -4.69% -3.17%
largestContentfulPaint 80 ms +0% -0% 80 ms +2.5% -2.5% 0%
lcpMinusTtfb 44.9 ms +1% -3.67% 43.45 ms +2.99% -2.88% 3.34%
wpBeforeTemplate 19.45 ms +5.35% -3.19% 19.76 ms +6.68% -3.34% -1.57%
wpTemplate 13.05 ms +1.92% -2.68% 13.6 ms +3.82% -7.28% -4.04%
wpTotal 32.49 ms +5.91% -1.75% 33.4 ms +6.5% -4.34% -2.72%
wpMemoryUsage 6.35 MB +0% -0% 6.32 MB +0% -0% 0.54%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 8875852 trunk % Change
mediaProcessingJpeg 324.32 ms +0.1% -1.13% 326.22 ms +3.04% -0.69% -0.58%
mediaProcessingAvif 4824.58 ms +0.52% -0.04% 4867.72 ms +0.42% -0.08% -0.89%
mediaProcessingJpegToAvif 3380.81 ms +0.15% -0.38% 3391.61 ms +0.09% -0.24% -0.32%

media-upload

Metric 8875852 trunk % Change
jpegUploadProcessing 1441.93 ms +32.95% -0.17% 1417.21 ms +2.1% -0.64% 1.74%
pngUploadProcessing 219.96 ms +13.63% -9.21% 226.07 ms +6.13% -4.15% -2.7%
largeJpegUploadProcessing 1417.25 ms +0.61% -0.72% 1414.63 ms +0.71% -0.81% 0.19%
multipleImageUploadProcessing 1514.45 ms +2.3% -0.44% 1536.45 ms +1.06% -0.51% -1.43%

post-editor

Metric 8875852 trunk % Change
serverResponse 365.37 ms +2.19% -8.94% 361.33 ms +2.69% -2.96% 1.12%
firstPaint 401.98 ms +3.12% -41.26% 412.17 ms +1.83% -0.07% -2.47%
domContentLoaded 908.84 ms +3.84% -1% 907.91 ms +2.7% -0.69% 0.1%
loaded 909.7 ms +3.85% -0.99% 908.79 ms +2.69% -0.69% 0.1%
firstContentfulPaint 412.87 ms +3.78% -0.97% 414.58 ms +1.59% -0.61% -0.41%
firstBlock 2686.25 ms +3.99% -3.41% 2617.9 ms +2.46% -1.99% 2.61%
type 16.14 ms +7.68% -0.74% 16.23 ms +4% -6.47% -0.55%
typeWithoutInspector 16.06 ms +16.06% -5.17% 15.58 ms +2.7% -3.34% 3.08%
typeWithTopToolbar 20.57 ms +11.13% -1.31% 20.47 ms +7.23% -0.83% 0.49%
typeContainer 8.36 ms +1.91% -2.15% 7.99 ms +9.64% -1.13% 4.63%
focus 103.23 ms +1.94% -4.4% 99.77 ms +4.31% -4.73% 3.47%
firstFocus 188.6 ms +0% -0% 191.23 ms +0% -0% -1.38%
selectAll 387.53 ms +2.94% -6.4% 375.65 ms +2.69% -1.77% 3.16%
listViewOpen 66.37 ms +11.26% -5.09% 66.31 ms +4.93% -8.97% 0.09%
inserterOpen 35.82 ms +14.21% -2.88% 34.51 ms +8.58% -4% 3.8%
inserterHover 10.14 ms +7.89% -6.51% 10.22 ms +4.89% -9% -0.78%
inserterSearch 7.76 ms +11.98% -6.83% 7.18 ms +7.52% -2.23% 8.08%
loadPatterns 544.29 ms +1.15% -3.5% 533.72 ms +3.58% -2.95% 1.98%
wpTotal 355.92 ms +2.2% -8.93% 352.12 ms +2.87% -3.14% 1.08%
wpMemoryUsage 14.70 MB +0% -0% 14.66 MB +0% -0% 0.24%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric 8875852 trunk % Change
serverResponse 511.01 ms +5.98% -1.55% 511.59 ms +2.6% -4.69% -0.11%
firstPaint 225.75 ms +27.83% -11.26% 293.98 ms +20.22% -20.07% -23.21%
domContentLoaded 1283.52 ms +0.4% -0.35% 1272.55 ms +4.01% -1.5% 0.86%
loaded 1284.6 ms +0.41% -0.35% 1273.87 ms +4.01% -1.52% 0.84%
firstContentfulPaint 522.84 ms +1.29% -3.77% 502.54 ms +4.46% -9.81% 4.04%
firstBlock 4867.94 ms +0.69% -0.6% 4795.76 ms +1.11% -0.61% 1.51%
type 19.72 ms +4.16% -5.17% 19.08 ms +7.23% -3.83% 3.35%
navigate 136.57 ms +7.67% -7.16% 115.67 ms +23.71% -4.04% 18.07%
loadPatterns 1338.82 ms +1.92% -2.89% 1301.62 ms +5.04% -1.45% 2.86%
loadPages 1031.16 ms +1.95% -4.53% 966.7 ms +3.77% -1.71% 6.67%
wpTotal 501.18 ms +6.16% -1.53% 502.26 ms +2.69% -4.72% -0.22%
wpMemoryUsage 12.71 MB +0% -0% 12.68 MB +0% -0% 0.27%
wpDbQueries 44 +2.27% -0% 44 +2.27% -0% 0%

08c60b4 Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Regression: updating a specific option will only change its value and will not corrupt others in /test/e2e/specs/editor/various/core-settings.spec.js, passed after 1 failed attempt.
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
    "rewrite_rules",
-   "SERIALIZED DATA",
+   "",
  ]
    at forEach (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:46:26)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:43:35
refuses the drop and uploads nothing in /test/e2e/specs/editor/various/single-file-placeholder-drop.spec.js, passed after 1 failed attempt.
Error: expect(received).toHaveLength(expected)

Expected length: 0
Received length: 1
Received array:  [{"_links": {"about": [{"href": "http://localhost:8889/wp-json/wp/v2/types/attachment"}], "author": [{"embeddable": true, "href": "http://localhost:8889/wp-json/wp/v2/users/1"}], "collection": [{"href": "http://localhost:8889/wp-json/wp/v2/media"}], "curies": [{"href": "https://api.w.org/{rel}", "name": "wp", "templated": true}], "replies": [{"embeddable": true, "href": "http://localhost:8889/wp-json/wp/v2/comments?post=223"}], "self": [{"href": "http://localhost:8889/wp-json/wp/v2/media/223", "targetHints": {"allow": ["GET", "POST", "PUT", "PATCH", "DELETE"]}}], "wp:attached-to": [{"embeddable": true, "href": "http://localhost:8889/wp-json/wp/v2/posts/222", "id": 222, "post_type": "post"}]}, "alt_text": "", "author": 1, "caption": {"rendered": ""}, "class_list": ["post-223", "attachment", "type-attachment", "status-inherit", "hentry", "entry"], "comment_status": "open", "date": "2026-10-21T22:58:18", "date_gmt": "2026-10-21T22:58:18", "description": {"rendered": "<p class=\"attachment\"><a href='http://localhost:8889/wp-content/uploads/2026/10/6a318dc2-522c-4d38-9d05-84d7c1e06b46.png'><img loading=\"lazy\" decoding=\"async\" width=\"10\" height=\"10\" src=\"http://localhost:8889/wp-content/uploads/2026/10/6a318dc2-522c-4d38-9d05-84d7c1e06b46.png\" class=\"attachment-medium size-medium\" alt=\"\" style=\"width:100%;height:100%;max-width:10px;\" /></a></p>
"}, "featured_media": 0, "filename": "6a318dc2-522c-4d38-9d05-84d7c1e06b46.png", "filesize": 80, "guid": {"rendered": "http://localhost:8889/wp-content/uploads/2026/10/6a318dc2-522c-4d38-9d05-84d7c1e06b46.png"}, "id": 223, "link": "http://localhost:8889/?attachment_id=223", "media_details": {"file": "2026/10/6a318dc2-522c-4d38-9d05-84d7c1e06b46.png", "filesize": 80, "height": 10, "image_meta": {"alt": "", "aperture": "0", "camera": "", "caption": "", "copyright": "", "created_timestamp": "0", "credit": "", "focal_length": "0", "iso": "0", "keywords": [], "orientation": "0", "shutter_speed": "0", "title": ""}, "sizes": {}, "width": 10}, "media_type": "image", "meta": [], "mime_type": "image/png", "modified": "2026-10-21T22:58:18", "modified_gmt": "2026-10-21T22:58:18", "ping_status": "closed", "post": 222, "slug": "6a318dc2-522c-4d38-9d05-84d7c1e06b46", "source_url": "http://localhost:8889/wp-content/uploads/2026/10/6a318dc2-522c-4d38-9d05-84d7c1e06b46.png", "status": "inherit", "template": "", "title": {"rendered": "6a318dc2-522c-4d38-9d05-84d7c1e06b46"}, "type": "attachment"}]
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/single-file-placeholder-drop.spec.js:71:45

08c60b4 Run

@jasmussen

Copy link
Copy Markdown
Contributor Author

Noting here that I deliberately created a different icon for "Form button" rather than reusing the existing "Button" icon, to denote that they are different. One is a decorative block, the other is literally the button HTML element for use inside forms, such as the comments form.

@jasmussen
jasmussen marked this pull request as draft October 6, 2026 09:37
@jasmussen

Copy link
Copy Markdown
Contributor Author

Converting to draft as there are some questions on whether we want to land these or not.

MaggieCabrera added a commit that referenced this pull request Oct 19, 2026
Whether elements need icons is still open in #84074, so start without
them and drop the formInput icon this PR added to @wordpress/icons.
Also restore the icons changelog line this PR reformatted by accident.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieCabrera added a commit that referenced this pull request Oct 19, 2026
Whether elements need icons is still open in #84074, so start without
them and drop the formInput icon this PR added to @wordpress/icons.
Also restore the icons changelog line this PR reformatted by accident.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieCabrera added a commit that referenced this pull request Oct 19, 2026
* Global Styles: Add Forms section

* Global Styles: Add Elements section

* Global Styles: Give elements their own home and the full control set

Blocks and elements are listed together under one item in the main Styles
menu, so there is a single place to style anything on the site. Inputs,
selects and buttons are grouped under Form controls.

Elements now offer the background, spacing, border, shadow and custom CSS
controls that theme.json already accepts and the styles engine already
emits, instead of typography and colour alone. Sizing, block gap, text
alignment and duotone stay out: the first three belong to the block that
contains an element, and the engine emits nothing for the last two.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Global Styles: Preview elements with the site's own styles

An element was previewed as a letter specimen built from a handful of
properties copied across by hand, so it could not react to the border,
shadow, spacing or background controls elements now have.

Each element is previewed instead as a sample of the markup its selector
applies to, rendered in the editor iframe with the generated stylesheet.
The sample picks up the cascade, the theme's fonts and every panel without
a list of properties to keep in sync.

Text color and background color are left to the Typography and Background
panels, where they were relocated in #77279, rather than shown a second
time in a Colors panel.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Global Styles: List elements in one flat list with blocks

Elements sit in the same list as blocks under Elements, Headings and Form
controls subheadings, with no drilldowns between them, so everything that
can be styled is one screen away and easy to find alongside blocks. Each
heading level is its own row, and the button element is labelled to tell
it apart from the Button block further down the list.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Global Styles: Resolve an element's styles once per screen

The typography panel had its own wrapper that read the element's styles and
settings a second time, separately from the panels beside it. One component
now resolves them and renders every panel.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Global Styles: Share border handling and the CSS capability check

The block and element screens each carried their own copy of the border
reconciliation and of the check for whether custom CSS may be edited. Both
now use one shared version.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Global Styles: Restore the Text and All headings entries and fix CI

Bring back the root Text screen under Typography, which the style
variations tests depend on, and list "All headings" at the top of the
Headings group so the shared `elements.heading` node themes style can
still be edited. Update the unit expectations for the widened element
supports, the e2e labels for the renamed "Blocks & Elements" screen,
and add the PR links the changelog check requires.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Global Styles: Reformat for the wp-prettier upgrade on trunk

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Icons: Move the formInput changelog entry to Unreleased

The rebase left the entry under the published 17.0.0 section, which
fails the changelog checks. Also restore the formatting of an older
entry the branch had touched without reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Mention elements in the Blocks & Elements description

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Blocks: Keep text alignment for elements in Global Styles

Text alignment was added to elements in #73854, and the element
screens should keep offering it alongside the new panels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Offer states on the link and button element screens

Moving the element colors out of the Colors screen dropped the only
control for link hover color. The link and button element screens
now offer the states the package already defines for them, and follow
the setting that turns off state editing for blocks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Show the default background size on element screens

An element's background image with no size renders with cover, as a
block's does, so the element screens now show the same defaults as
the block screen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Use one route for the element screens

The block list's elements now open through a single path with the
element name as a parameter, instead of one route per element.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Share element titles between the list and their screens

The Blocks & Elements list now reads each element's label from the
element screen's table, so the two cannot drift apart. The Button
element's screen is titled "Button (element)" to match its row and
tell it apart from the Button block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Restore trunk's formatting of a media query

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Drop the deprecated spacer from the element screen

The preview's own class now sets its side margin, and no longer
shrinks inside the screen's scrolling flex column. This removes the
element screen's use-recommended-components suppression.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Keep trunk's Text row under Typography

Restore trunk's Typography element list with only the Text row, instead
of rebuilding it inline. The row keeps its sample in the site's font,
and the other elements stay in the Blocks & Elements list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Move this PR's changelog entries back under Unreleased

Trunk published new releases, so the rebase left the entries under
published versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Drop the custom styles dot from element rows

Trunk removed the dot from block rows in #84657. Element rows follow,
and the customized filter keeps working for both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Keep the border helper in the block screen

Trunk's fallback helpers stay where they were, and the border
handling the element screen shares becomes an exported function next
to them, instead of a new file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Inline the customized check for elements

The element list calls the existing value check directly instead of
a separate exported wrapper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Check that searching lists matching elements

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Style Book: Show the Text category on element screens

Element screens moved under the Blocks & Elements path, so the Style
Book showed every block for them instead of the Text category it
showed when they lived under Typography.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: Match element names and group titles in search

Searching "h1" now finds Heading 1, and "form" lists the form
controls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix the formatting of the heading styles end-to-end test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update the ESLint suppressions after rebasing on trunk

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Blocks: Leave the layout widths out of element styles

Elements started from the root supports, so they kept contentSize and
wideSize. The element screen never renders the width controls, but the
Dimensions panel still counted them and showed up empty on themes that
set layout widths without padding or margin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Global Styles: List elements without icons

Whether elements need icons is still open in #84074, so start without
them and drop the formInput icon this PR added to @wordpress/icons.
Also restore the icons changelog line this PR reformatted by accident.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update packages/editor/src/components/global-styles/block-link.js

Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
@jasmussen
jasmussen marked this pull request as ready for review October 21, 2026 10:40

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and tested on storybook

Noting here that I deliberately created a different icon for "Form button" rather than reusing the existing "Button" icon, to denote that they are different.

@jasmussen just to confirm there are only two icons in this PR and the form button will just used "button"?

Image Image

@andrewserong

Copy link
Copy Markdown
Contributor

just to confirm there are only two icons in this PR and the form button will just used "button"?

That was my understanding from #81645 (comment) 👍

@andrewserong andrewserong added the Backport to WP 7.2 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 21, 2026
@andrewserong

Copy link
Copy Markdown
Contributor

Just adding the backport to WP 7.2 Beta label as this will be a pre-requisite for polishing #81645 which will be in 7.2.

@andrewserong
andrewserong merged commit a5b8ddb into trunk Oct 21, 2026
94 checks passed
@andrewserong
andrewserong deleted the add/form-icons branch October 21, 2026 23:35
@github-actions github-actions Bot added this to the Gutenberg 24.4 milestone Oct 21, 2026
@andrewserong andrewserong added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Oct 21, 2026
@github-actions

Copy link
Copy Markdown

There was a conflict while trying to cherry-pick the commit to the wp/7.2 branch. Please resolve the conflict manually and create a PR to the wp/7.2 branch.

PRs to wp/7.2 are similar to PRs to trunk, but you should base your PR on the wp/7.2 branch instead of trunk.

# Checkout the wp/7.2 branch instead of trunk.
git checkout wp/7.2

# Create a new branch for your PR.
git checkout -b my-branch

# Cherry-pick the commit.
git cherry-pick a5b8ddb29c33b4972717871aebe9397c29b0a456

# Check which files have conflicts.
git status

# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue

# Push the branch to the repository
git push origin my-branch

# Create a PR and set the base to the wp/7.2 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

1 similar comment
@github-actions

Copy link
Copy Markdown

There was a conflict while trying to cherry-pick the commit to the wp/7.2 branch. Please resolve the conflict manually and create a PR to the wp/7.2 branch.

PRs to wp/7.2 are similar to PRs to trunk, but you should base your PR on the wp/7.2 branch instead of trunk.

# Checkout the wp/7.2 branch instead of trunk.
git checkout wp/7.2

# Create a new branch for your PR.
git checkout -b my-branch

# Cherry-pick the commit.
git cherry-pick a5b8ddb29c33b4972717871aebe9397c29b0a456

# Check which files have conflicts.
git status

# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue

# Push the branch to the repository
git push origin my-branch

# Create a PR and set the base to the wp/7.2 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

@andrewserong

Copy link
Copy Markdown
Contributor

Looks like the changelog has a merge conflict when trying to get it into the 7.2 branch. I'll throw up a quick PR to cherry pick this one into the release branch.

@andrewserong

andrewserong commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Cherry pick PR: #85360
Update: merged.

andrewserong added a commit that referenced this pull request Oct 22, 2026
* Icons: Add new form based icons.

* Update changelog.

* Remove form-button icon, normalize form icons for scaling strokes

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
@andrewserong andrewserong added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 7.2 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown

There was a conflict while trying to cherry-pick the commit to the wp/7.2 branch. Please resolve the conflict manually and create a PR to the wp/7.2 branch.

PRs to wp/7.2 are similar to PRs to trunk, but you should base your PR on the wp/7.2 branch instead of trunk.

# Checkout the wp/7.2 branch instead of trunk.
git checkout wp/7.2

# Create a new branch for your PR.
git checkout -b my-branch

# Cherry-pick the commit.
git cherry-pick a5b8ddb29c33b4972717871aebe9397c29b0a456

# Check which files have conflicts.
git status

# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue

# Push the branch to the repository
git push origin my-branch

# Create a PR and set the base to the wp/7.2 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

@andrewserong

Copy link
Copy Markdown
Contributor

Ignore the above comment: the cherry pick PR has been merged (#85360)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) Backported to WP Core Pull request that has been successfully merged into WP Core [Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants