Repository navigation
Conversation
The inspector preview used an unstyled Video poster class, so a large track image overflowed the sidebar.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #83858.
The Playlist Track inspector's Track image preview rendered at the image's natural size. A large or tall image overflowed the sidebar and stretched the settings panel.
Why
The preview wrapper used
editor-video-poster-control, a leftover class from the Video block's old poster control. That class has no styles in the current editor stylesheet, so the<img>was unconstrained.How
The preview uses a Playlist Track class,
wp-block-playlist-track__inspector-image, with editor styles that cap the image at the sidebar width and a 200px max height (object-fit: contain). Select / Replace / Remove stay on the same control.Testing Instructions
Use of AI Tools
None