Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 5, 2026 19:56
94bab3d to
f22f913
Compare
desrosj
marked this pull request as ready for review
October 7, 2026 13:17
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 7, 2026 13:42
f22f913 to
3ec3564
Compare
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 7, 2026 15:58
3ec3564 to
8b0c1ee
Compare
desrosj
removed this pull request from stack #83630
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-7.0/pin-mariadb-version
to
wp/7.0
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 7, 2026 18:16
8b0c1ee to
287e04b
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/pin-mariadb-version
October 7, 2026 18:17
desrosj
added this pull request to stack #84187
October 7, 2026 18:18
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84187
October 8, 2026 21:10
desrosj
changed the base branch from
fix-actions-7.0/pin-mariadb-version
to
wp/7.0
October 8, 2026 21:11
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 8, 2026 21:12
287e04b to
cf07995
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/pin-mariadb-version
October 8, 2026 21:13
desrosj
added this pull request to stack #84347
October 8, 2026 21:13
desrosj
removed this pull request from stack #84347
October 9, 2026 23:27
desrosj
changed the base branch from
fix-actions-7.0/pin-mariadb-version
to
wp/7.0
October 9, 2026 23:28
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 9, 2026 23:28
cf07995 to
39c2f22
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/pin-mariadb-version
October 9, 2026 23:30
desrosj
added this pull request to stack #84468
October 9, 2026 23:30
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 19, 2026 17:04
39c2f22 to
e7cd7c3
Compare
desrosj
removed this pull request from stack #84468
October 21, 2026 18:35
desrosj
added this pull request to stack #85325
October 21, 2026 18:35
desrosj
force-pushed
the
fix-actions-7.0/detect-db-client-in-debug-step
branch
from
October 23, 2026 17:27
e7cd7c3 to
8244fc1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82782.
What?
Makes the database line of
unit-test.yml's "Docker container debug information" step work with any MySQL or MariaDB version. It now runsmariadb --versionwhen the database container has amariadbclient, andmysql --versionwhen it doesn't.Why?
The client's name depends on the database version, and this branch supports MySQL and MariaDB back to 5.5:
mysql.mariadb: themysqlalias was removed.A fixed name fails on part of that range, so the step checks which client exists before running it. WordPress Core's test environment makes the same distinction by version (WordPress/wordpress-develop@ea80ac8).
How?
The line runs a short
sh -cscript in themysqlcontainer (the tests database ofwp-env-test). The--beforeshpasses the script to the container withoutwp-envparsing it.Tested against MariaDB 5.5, 10.0, 10.3, 10.4, 10.5, 10.6, 10.11, 11.4, 11.8, 12.3 and 13.0 and MySQL 5.5, 5.6, 5.7, 8.0 and 8.4: each prints its client version and exits successfully.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code