Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
1acc748 to
126290b
Compare
126290b to
fdba07c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fdba07c to
0387872
Compare
0387872 to
757e6d4
Compare
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
757e6d4 to
3ef4f9c
Compare
3ef4f9c to
b69d431
Compare
Part of #82930.
What?
Adds a
mariadbVersionoption to.wp-env.jsonand aWP_ENV_MARIADB_VERSIONenvironment variable towp-env, so the MariaDB version it uses can be chosen..wp-env.jsonor per environment (env.development,env.tests), likephpVersion.WP_ENV_MARIADB_VERSIONoverrides both environments."lts","latest", or a numeric version such as"10.11"or"11.4.2". Anything else fails validation, in the config file or the environment variable.mariadbimage exactly as it is; a set version becomesmariadb:<version>.packages/env/CHANGELOG.mdgets an entry.wp-env destroybefore switching to a lower version, and that it removes the environment's Docker containers, volumes, networks, images, and local files, not only the databases. Its ARM note covers MariaDB 5.5 only (10.0 has ARM images) and says thatDOCKER_DEFAULT_PLATFORMruns every container under emulation.Why?
This branch's
wp-env(8.1.3) always runs a floating MariaDB image, which keeps moving to releases far newer than anything WordPress 6.3 was released against. There's no way to pin an era-appropriate version for testing. #83827, later in this stack, uses this option to do that.How?
This ports #83751. This branch has no
schemas/json/wp-env.jsonand no database health check, so neither applies; only the image tag inlib/build-docker-compose-config.jschanges. The config parsing, environment variable and validation (checkMariaDBVersion()) match trunk, adapted to this branch's files. #83751's downgrade error and stricterphpVersioncheck are not ported. Itswp dbclient wrappers come later in this stack, in #83868.The unit tests for the validator, the config parsing and the compose output are ported too, and the config snapshot gains
"mariadbVersion": null.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code