Skip to content

Repair wp/6.4 branch Actions: Pass debug step arguments through to wp-env - #83805

Open
desrosj wants to merge 1 commit into
fix-actions-6.4/fix-flaky-site-editor-url-navigationfrom
fix-actions-6.4/fix-debug-step-arguments
Open

desrosj wants to merge 1 commit into
fix-actions-6.4/fix-flaky-site-editor-url-navigationfrom
fix-actions-6.4/fix-debug-step-arguments

Conversation

@desrosj

@desrosj desrosj commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Part of #82929.

What?

Adds -- right after npm run wp-env in each command of unit-test.yml's "Docker container debug information" step, so npm passes the whole command through to wp-env unchanged.

Why?

Without it, npm treats the rest of the arguments as its own: it drops the -- separator and swallows short flags such as -m, -i and -a. None of the step's commands ran as written:

  • mysql -- --version, php -- --version and phpunit -- --version reached wp-env as its own --version flag, so each printed the wp-env version.
  • php -m and php -i ran as a bare php, and locale -a as a bare locale.

The step passed without logging any of the information it exists for.

Now that the commands really run, the mysql --version line fails: this branch's floating mariadb image is MariaDB 11.0 or later, which no longer includes the mysql alias for the mariadb client. The next PR in this stack, #83838, fixes that.

Upstream

trunk has used the same form (npm run wp-env-test -- run …) since #75341.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 30, 2026
@desrosj desrosj self-assigned this Sep 30, 2026
@desrosj
desrosj added this pull request to stack #83741 September 30, 2026 00:42
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d0199dad-929d-4dc7-9a1d-8995cdc09062

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from 7ac13c1 to ebe5eb2 Compare October 2, 2026 20:00
@desrosj
desrosj removed this pull request from stack #83741 October 7, 2026 18:11
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-flaky-site-editor-url-navigation to wp/6.4 October 7, 2026 18:13
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from ebe5eb2 to 318fffe Compare October 7, 2026 18:14
@github-actions github-actions Bot added [Tool] WP Scripts /packages/scripts [Tool] E2E Test Utils /packages/e2e-test-utils-playwright [Tool] Env /packages/env labels Oct 7, 2026
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/fix-flaky-site-editor-url-navigation October 7, 2026 18:20
@desrosj
desrosj added this pull request to stack #84191 October 7, 2026 18:20
@desrosj
desrosj marked this pull request as ready for review October 8, 2026 03:01
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #84191 October 8, 2026 21:38
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-flaky-site-editor-url-navigation to wp/6.4 October 8, 2026 21:39
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from 318fffe to 978b4b5 Compare October 8, 2026 21:40
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/fix-flaky-site-editor-url-navigation October 8, 2026 21:41
@desrosj
desrosj added this pull request to stack #84353 October 8, 2026 21:42
@github-actions github-actions Bot removed [Tool] WP Scripts /packages/scripts [Tool] E2E Test Utils /packages/e2e-test-utils-playwright [Tool] Env /packages/env labels Oct 8, 2026
@desrosj
desrosj removed this pull request from stack #84353 October 9, 2026 23:54
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-flaky-site-editor-url-navigation to wp/6.4 October 9, 2026 23:55
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from 978b4b5 to 4dec710 Compare October 9, 2026 23:56
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/fix-flaky-site-editor-url-navigation October 9, 2026 23:58
@desrosj
desrosj added this pull request to stack #84480 October 9, 2026 23:58
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from 4dec710 to 312cf70 Compare October 13, 2026 01:54
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from 312cf70 to 3668472 Compare October 19, 2026 17:06
@desrosj
desrosj removed this pull request from stack #84480 October 21, 2026 19:42
@desrosj
desrosj added this pull request to stack #85340 October 21, 2026 19:43
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from 3668472 to c3e186f Compare October 23, 2026 17:09
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-debug-step-arguments branch from c3e186f to 7fb3a68 Compare October 23, 2026 18:12

@andrewserong andrewserong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants