Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
255e530 to
baeb91d
Compare
baeb91d to
ec4a471
Compare
ec4a471 to
a7670ce
Compare
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
a7670ce to
2849af1
Compare
2849af1 to
7584570
Compare
7584570 to
81f1f46
Compare
81f1f46 to
33adb8f
Compare
33adb8f to
7f6cc5b
Compare
Part of #82928.
What?
Adds
--right afternpm run wp-envin each command ofunit-test.yml's "Docker container debug information" step, so npm passes the whole command through towp-envunchanged.Why?
Without it, npm treats the rest of the arguments as its own: it drops the
--separator and swallows short flags such as-m,-iand-a. None of the step's commands ran as written:mysql -- --version,php -- --versionandphpunit -- --versionreachedwp-envas its own--versionflag, so each printed thewp-envversion.php -mandphp -iran as a barephp, andlocale -aas a barelocale.The step passed without logging any of the information it exists for.
Now that the commands really run, the
mysql --versionline fails: this branch's floatingmariadbimage is MariaDB 11.0 or later, which no longer includes themysqlalias for themariadbclient. The next PR in this stack, #83837, fixes that.Upstream
trunkhas used the same form (npm run wp-env-test -- run …) since #75341.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code