Repository navigation
Repair wp/6.8 branch Actions: Pass debug step arguments through to wp-env - #83801
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cb21709 to
88ce56e
Compare
88ce56e to
fdec8ab
Compare
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fdec8ab to
6398467
Compare
6398467 to
6dc234d
Compare
6dc234d to
78da86d
Compare
78da86d to
30ab50a
Compare
Part of #82786.
What?
Adds
--right afternpm run wp-envin each command ofunit-test.yml's "Docker container debug information" step, so npm passes the whole command through towp-envunchanged.Why?
Without it, npm treats the rest of the arguments as its own: it drops the
--separator and swallows short flags such as-m,-iand-a. Onlywp core version, which has no flags, ran as written:mysql -- --version,php -- --versionandphpunit -- --versionreachedwp-envas its own--versionflag, so each printed thewp-envversion.php -mandphp -iran as a barephp, andlocale -aas a barelocale.The step passed without logging most of the information it exists for.
Now that the commands really run, the
mysql --versionline fails: this branch'smariadb:ltsimage is MariaDB 11.0 or later, which no longer includes themysqlalias for themariadbclient. The next PR in this stack, #83834, fixes that.Upstream
trunkhas used the same form (npm run wp-env-test -- run …) since #75341.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code