Skip to content

Try: Smaller/refined external link icon. - #83767

Closed
jasmussen wants to merge 1 commit into
trunkfrom
try/update-external-icon
Closed

Try: Smaller/refined external link icon.#83767
jasmussen wants to merge 1 commit into
trunkfrom
try/update-external-icon

Conversation

@jasmussen

@jasmussen jasmussen commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

What?

Updates the External Link icon to adjust the balance.

This is the design work of @fcoveram, I'm just creating a stroke-based PR from it.

Before and after:

image

Testing Instructions

npm run storybook:dev, observe the "external" icon in context of the others.

Use of AI Tools

Claude ran a normalisation script that I plan to submit separately to trunk when I get a chance.

@jasmussen
jasmussen requested a review from a team September 29, 2026 08:52
@jasmussen jasmussen self-assigned this Sep 29, 2026
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Package] Icons /packages/icons labels Sep 29, 2026
@jasmussen
jasmussen requested a review from fcoveram September 29, 2026 08:52
@github-actions

github-actions Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: fcoveram <fcoveram@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 39038c4 trunk % Change
timeToFirstByte 57.35 ms +10.29% -6.36% 54.8 ms +12.59% -2.46% 4.65%
largestContentfulPaint 96 ms +8.33% -4.17% 92 ms +4.35% -4.35% 4.35%
lcpMinusTtfb 36.1 ms +18.28% -5.82% 33.6 ms +9.52% -6.25% 7.44%
wpBeforeTemplate 27.54 ms +14.45% -2.76% 26.75 ms +21.08% -1.23% 2.95%
wpTemplate 24.43 ms +5.03% -4.67% 24.33 ms +2.06% -4.52% 0.41%
wpTotal 53.21 ms +10.15% -6.62% 50.97 ms +13.05% -2.53% 4.39%
wpMemoryUsage 7.62 MB +0% -0% 7.58 MB +0% -0% 0.51%
wpDbQueries 17 +0% -0% 17 +0% -0% 0%

front-end-classic-theme

Metric 39038c4 trunk % Change
timeToFirstByte 44.8 ms +5.8% -1% 44.15 ms +5.44% -0.68% 1.47%
largestContentfulPaint 100 ms +4% -0% 100 ms +4% -4% 0%
lcpMinusTtfb 55.55 ms +1.62% -0.63% 55.85 ms +1.16% -6% -0.54%
wpBeforeTemplate 23.81 ms +1.6% -1.01% 23.63 ms +3.13% -1.48% 0.76%
wpTemplate 17.83 ms +4.66% -1.23% 17.5 ms +1.71% -1.6% 1.89%
wpTotal 41.61 ms +6.39% -0.79% 41 ms +5.24% -1.12% 1.49%
wpMemoryUsage 6.24 MB +0% -0% 6.20 MB +0% -0% 0.58%
wpDbQueries 14 +0% -0% 14 +0% -0% 0%

media-processing

Metric 39038c4 trunk % Change
mediaProcessingJpeg 415.2 ms +2.04% -0.53% 409.66 ms +1.24% -1.11% 1.35%
mediaProcessingAvif 6168.87 ms +0.19% -0.24% 6155.5 ms +0.25% -0.17% 0.22%
mediaProcessingJpegToAvif 4316.12 ms +0.27% -0.06% 4324.13 ms +0.2% -0.2% -0.19%

media-upload

Metric 39038c4 trunk % Change
jpegUploadProcessing 1427.19 ms +35.67% -0.33% 1432.9 ms +0.6% -0.59% -0.4%
pngUploadProcessing 206.33 ms +3.18% -8.42% 219.5 ms +1.2% -5.96% -6%
largeJpegUploadProcessing 1419.7 ms +0.13% -0.39% 1419.7 ms +0.75% -0.97% 0%
multipleImageUploadProcessing 1614.66 ms +29.65% -2.7% 1567.53 ms +9.54% -1.32% 3.01%

post-editor

Metric 39038c4 trunk % Change
serverResponse 510.71 ms +8.51% -5.21% 526.83 ms +4.72% -4.23% -3.06%
firstPaint 223.11 ms +13.24% -13.18% 236.64 ms +21.54% -12.68% -5.72%
domContentLoaded 1146.68 ms +1.49% -2.43% 1134.62 ms +1.82% -1.95% 1.06%
loaded 1148.14 ms +1.47% -2.46% 1135.95 ms +1.81% -1.97% 1.07%
firstContentfulPaint 464.97 ms +3.1% -1.42% 447.04 ms +5.31% -3.1% 4.01%
firstBlock 3456.59 ms +1.6% -3.43% 3453.45 ms +0.75% -0.83% 0.09%
type 17.04 ms +7.34% -2.41% 18.03 ms +12.04% -3.16% -5.49%
typeWithoutInspector 17.93 ms +8.37% -3.46% 19.12 ms +10.67% -7.64% -6.22%
typeWithTopToolbar 24.48 ms +1.51% -5.6% 24.03 ms +7.53% -1.71% 1.87%
typeContainer 1.45 ms +15.86% -37.24% 1.28 ms +13.28% -41.41% 13.28%
focus 14.8 ms +15.74% -9.93% 14.41 ms +7.15% -9.02% 2.71%
firstFocus 31.68 ms +0% -0% 29.92 ms +0% -0% 5.88%
selectAll 1561.88 ms +0.67% -0.46% 1509.45 ms +0.92% -0.75% 3.47%
listViewOpen 61.74 ms +20.83% -3.63% 61.9 ms +11.66% -2.08% -0.26%
inserterOpen 24.23 ms +6.6% -5.65% 25.09 ms +9.41% -13.75% -3.43%
inserterHover 2.51 ms +11.55% -18.33% 2.17 ms +7.83% -11.52% 15.67%
inserterSearch 8.81 ms +11.69% -11.58% 7.63 ms +18.87% -4.59% 15.47%
loadPatterns 697.88 ms +2.62% -5.03% 645.02 ms +2.67% -3.96% 8.2%
wpTotal 500.39 ms +8.74% -5.32% 516.21 ms +4.83% -4.17% -3.06%
wpMemoryUsage 13.16 MB +0% -0% 13.12 MB +0% -0% 0.28%
wpDbQueries 54 +0% -1.85% 54 +0% -1.85% 0%

site-editor

Metric 39038c4 trunk % Change
serverResponse 499.13 ms +5.18% -5.25% 487.24 ms +3.92% -4.05% 2.44%
firstPaint 258.88 ms +4.73% -10.36% 261.92 ms +29.08% -10.06% -1.16%
domContentLoaded 1143.51 ms +3.39% -0.79% 1135.17 ms +1.36% -1.87% 0.73%
loaded 1144.69 ms +3.4% -0.79% 1136.32 ms +1.36% -1.86% 0.74%
firstContentfulPaint 453.23 ms +7.83% -1.56% 448.8 ms +2.58% -1.8% 0.99%
firstBlock 4184.88 ms +1.23% -0.51% 4178.61 ms +0.31% -1.03% 0.15%
type 16.95 ms +8.55% -2.95% 17.76 ms +5.18% -8.61% -4.56%
navigate 98.83 ms +27.34% -3.65% 112.73 ms +9.21% -11.38% -12.33%
loadPatterns 1309.7 ms +17.39% -4.01% 1332.05 ms +3.46% -2.06% -1.68%
loadPages 1058.07 ms +3.01% -1.22% 1076.37 ms +1.63% -0.67% -1.7%
wpTotal 489.34 ms +5.27% -5.31% 477.6 ms +4.08% -4.06% 2.46%
wpMemoryUsage 12.14 MB +0% -0% 12.10 MB +0% -0% 0.31%
wpDbQueries 43 +2.33% -0% 43 +2.33% -0% 0%

8fa7b3d Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Navigates the items list via UP/DOWN arrow keys in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js, passed after 1 failed attempt. 
Error: expect(locator).toBeFocused() failed

Locator:  getByLabel('Page Two')
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" getByLabel('Page Two') with timeout 5000ms
  - waiting for getByLabel('Page Two')
    14 × locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-227-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-227-label" aria-describedby="view-list-0-227-description"></button>
       - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:146:49

8fa7b3d Run

@jameskoster

jameskoster commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

What are we balancing with? Most of the 'square' icons in the set are currently based on either an 18 or 16px square. This one appears to be 13px which is a bit unexpected.

@fcoveram

fcoveram commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

It's a version for improving the optical size. It looks big and prominent next to a label, and its height is similar to that of other icons with wide shapes. These latter ones also don't have a consistent size.

Now that icons are stroke-based, maybe we can keep the current shape and try a combination of size and stroke width based on the text component and its variants. That would ensure coherence when icons are placed in isolation or next to a label.

@jasmussen

jasmussen commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing for now not because the effort is ongoing and there are discussions around footprint, size props, stroke width changes that may facilitate the end-goal through different means.

@jasmussen jasmussen closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcoveram fcoveram Awaiting requested review from fcoveram

Assignees

@jasmussen jasmussen

Labels

Needs Design Feedback Needs general design feedback. [Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasmussen @jameskoster @fcoveram