Repository navigation
Repair wp/6.3 branch Actions: Fix flaky site editor command palette e2e test - #83739
Closed
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
marked this pull request as ready for review
September 28, 2026 23:22
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.3/fix-flaky-command-center-template-test
branch
from
September 28, 2026 23:24
25742a3 to
56bf9f6
Compare
desrosj
force-pushed
the
fix-actions-6.3/fix-flaky-site-editor-url-navigation
branch
from
September 28, 2026 23:24
161b55d to
44da2ab
Compare
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #83715
September 28, 2026 23:47
Member
Author
|
Closing: the upstream fix ported here (#62454) looks for the template title in the "Editor top bar", which matches how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82930.
What?
Makes the "Open the command palette and navigate to a template" test in
test/e2e/specs/site-editor/command-center.spec.jslook for the level-1 heading inside the "Editor top bar" region, instead of anywhere on the page.Why?
After opening the "index" template, the test expects the page's level-1 heading to read "Index". It searched the whole page, so when a second level-1 heading was also present, Playwright's strict mode failed the assertion with "
getByRole('heading', { level: 1 })resolved to 2 elements". The template's title is shown in the document bar inside the editor top bar, so scoping the lookup there checks exactly what the test intends. This branch has the same page-wide assertion, so the fix is included for consistency.Upstream
A straight cherry-pick of
b7368c0(#62454) fromtrunk, which reachedwp/6.7but not this branch.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DtSAAJkQ9P6vPtDumqStg8